From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:37508 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbeB0WPB (ORCPT ); Tue, 27 Feb 2018 17:15:01 -0500 Received: by mail-wm0-f68.google.com with SMTP id 139so1459356wmn.2 for ; Tue, 27 Feb 2018 14:15:00 -0800 (PST) Subject: Re: [PATCH net-next 05/11] ipmr, ip6mr: Unite creation of new mr_table To: Yuval Mintz , netdev@vger.kernel.org Cc: mlxsw@mellanox.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org References: <1519757908-32863-1-git-send-email-yuvalm@mellanox.com> <1519757908-32863-6-git-send-email-yuvalm@mellanox.com> From: Nikolay Aleksandrov Message-ID: <9e416909-21bd-92f6-816d-695d8eaa16aa@cumulusnetworks.com> Date: Wed, 28 Feb 2018 00:14:57 +0200 MIME-Version: 1.0 In-Reply-To: <1519757908-32863-6-git-send-email-yuvalm@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 27/02/18 20:58, Yuval Mintz wrote: > Now that both ipmr and ip6mr are using the same mr_table structure, > we can have a common function to allocate & initialize a new instance. > > Signed-off-by: Yuval Mintz > --- > include/linux/mroute_base.h | 17 +++++++++++++++++ > net/ipv4/ipmr.c | 27 ++++++++++----------------- > net/ipv4/ipmr_base.c | 27 +++++++++++++++++++++++++++ > net/ipv6/ip6mr.c | 30 ++++++++++-------------------- > 4 files changed, 64 insertions(+), 37 deletions(-) > I don't like the function definition broken with the name and type on different rows, but I guess it's a personal preference, the patch looks okay. Acked-by: Nikolay Aleksandrov