From: Jacob Keller <jacob.e.keller@intel.com>
To: Chen Ni <nichen@iscas.ac.cn>, <kuba@kernel.org>,
<netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <arnd@arndb.de>
Subject: Re: [PATCH net v2] myri10ge: replace comma with semicolon to fix regression
Date: Thu, 12 Feb 2026 14:58:39 -0800 [thread overview]
Message-ID: <9e476352-e2b6-4a08-b5b9-88ba47bdbcbb@intel.com> (raw)
In-Reply-To: <20260212055028.3248491-1-nichen@iscas.ac.cn>
On 2/11/2026 9:50 PM, Chen Ni wrote:
> This fixes a regression introduced by commit fd24173439c0
> ("myri10ge: avoid uninitialized variable use"), where a comma was
> mistakenly used instead of a semicolon.
>
> Fixes: fd24173439c0 ("myri10ge: avoid uninitialized variable use")
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
At first, I was curious how this got into tree undetected...
Because this is C, and ',' expressions are valid.. So this just looks
like a bunch of chained assignment expressions which are all valid to
the compiler. Since none of these are "statements" its not *technically*
incorrect, though its definitely not how one normally writes this in C.
Strictly speaking this wouldn't be a visible regression (since at least
GCC doesn't complain) but:
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2026-02-12 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 5:50 [PATCH net v2] myri10ge: replace comma with semicolon to fix regression Chen Ni
2026-02-12 22:58 ` Jacob Keller [this message]
2026-02-13 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e476352-e2b6-4a08-b5b9-88ba47bdbcbb@intel.com \
--to=jacob.e.keller@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox