[PATCH net v2] myri10ge: replace comma with semicolon to fix regression

[PATCH net v2] myri10ge: replace comma with semicolon to fix regression

[Chen Ni]

This fixes a regression introduced by commit fd24173439c0
("myri10ge: avoid uninitialized variable use"), where a comma was
mistakenly used instead of a semicolon.

Fixes: fd24173439c0 ("myri10ge: avoid uninitialized variable use")
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
Changes in v2:
- Changed subject prefix from [net-next] to [net]
- Added Fixes tag
- Added Acked-by from Arnd Bergmann
---
 drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
index 2f0cdbd4e2ac..d9b5d7999370 100644
--- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
+++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
@@ -688,9 +688,9 @@ static int myri10ge_get_firmware_capabilities(struct myri10ge_priv *mgp)
 
 	/* probe for IPv6 TSO support */
 	mgp->features = NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_TSO;
-	cmd.data0 = 0,
-	cmd.data1 = 0,
-	cmd.data2 = 0,
+	cmd.data0 = 0;
+	cmd.data1 = 0;
+	cmd.data2 = 0;
 	status = myri10ge_send_cmd(mgp, MXGEFW_CMD_GET_MAX_TSO6_HDR_SIZE,
 				   &cmd, 0);
 	if (status == 0) {
@@ -821,9 +821,9 @@ static int myri10ge_change_pause(struct myri10ge_priv *mgp, int pause)
 	int status, ctl;
 
 	ctl = pause ? MXGEFW_ENABLE_FLOW_CONTROL : MXGEFW_DISABLE_FLOW_CONTROL;
-	cmd.data0 = 0,
-	cmd.data1 = 0,
-	cmd.data2 = 0,
+	cmd.data0 = 0;
+	cmd.data1 = 0;
+	cmd.data2 = 0;
 	status = myri10ge_send_cmd(mgp, ctl, &cmd, 0);
 
 	if (status) {
-- 
2.25.1

Re: [PATCH net v2] myri10ge: replace comma with semicolon to fix regression

[Jacob Keller]

On 2/11/2026 9:50 PM, Chen Ni wrote:
> This fixes a regression introduced by commit fd24173439c0
> ("myri10ge: avoid uninitialized variable use"), where a comma was
> mistakenly used instead of a semicolon.
> 
> Fixes: fd24173439c0 ("myri10ge: avoid uninitialized variable use")
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---

At first, I was curious how this got into tree undetected...

Because this is C, and ',' expressions are valid.. So this just looks 
like a bunch of chained assignment expressions which are all valid to 
the compiler. Since none of these are "statements" its not *technically* 
incorrect, though its definitely not how one normally writes this in C.

Strictly speaking this wouldn't be a visible regression (since at least 
GCC doesn't complain) but:

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

Re: [PATCH net v2] myri10ge: replace comma with semicolon to fix regression

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 12 Feb 2026 13:50:28 +0800 you wrote:
> This fixes a regression introduced by commit fd24173439c0
> ("myri10ge: avoid uninitialized variable use"), where a comma was
> mistakenly used instead of a semicolon.
> 
> Fixes: fd24173439c0 ("myri10ge: avoid uninitialized variable use")
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> 
> [...]

Here is the summary with links:
  - [net,v2] myri10ge: replace comma with semicolon to fix regression
    https://git.kernel.org/netdev/net/c/7c375811b511

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html