From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 546AF416D19 for ; Fri, 10 Jul 2026 11:25:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783682757; cv=none; b=TQfFm+zsBUDwQC2Lj85dqxuLikydGfc35l4EKTKHPZzuDxtQegXukkSuHbm7YKFoMT6uKzkca9zYAP6GgO0/bHMZq/hOBdrF3QhenTqEX/MdQp5+OfV9IZaNcaVkCzPUitSXvngl6IYUPnVVBnne9lqsv6UcYeTHPn5d5BGq1A8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783682757; c=relaxed/simple; bh=+O+11YFkdR9m/DePEM0XGB3bOHAzHPG87B7si8jQV+w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LHEn6yVfyOP6g7ToRrn/fDxG6UrT4HRqKQXVvVZRDPsa+i4IivRqSDgyM31TDuC1TRCT+GJMk/CxApBbUc4H4XjpBLNYf5vwm6qoIc/d0o+nMkATWyWisGBn+RVurnbbw1VoVrgor2HlyLKZIaaq1DDC/6t01AMVzeuXA/zU6Mk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GzcaPLYd; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=U/KvVqan; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GzcaPLYd"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="U/KvVqan" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783682750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GnpNr4qDyHoNfCA9ul8yyjujzs6stkD93LOWV1wBtX4=; b=GzcaPLYdk8gWU6NHu4Ga3NABE6sGenZl+2wRYIXJK4mUrDlxcrS+wOyWWLagycwQnxzEPQ dMr5s1rBx5Q1Uz5e1KjTNASaWPihY+shC9l0t8uFrMd4tzjdE/2hjYEZgBmRik80jF0Rzz AEtBhagqXwpoEZatLUOort3pHcCrBy0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-166--tdvSjwLMTGqsjDr2-OD-w-1; Fri, 10 Jul 2026 07:25:49 -0400 X-MC-Unique: -tdvSjwLMTGqsjDr2-OD-w-1 X-Mimecast-MFC-AGG-ID: -tdvSjwLMTGqsjDr2-OD-w_1783682748 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4729d2a64efso1100490f8f.0 for ; Fri, 10 Jul 2026 04:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783682748; x=1784287548; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=GnpNr4qDyHoNfCA9ul8yyjujzs6stkD93LOWV1wBtX4=; b=U/KvVqanNrJvUDoGPkv6jPbxvd9cenAPVqwmR41CQlt1xPFWD6t22GK6q7mA2fC2zz wkT7CMlIrjsDgQj9jqnIXgtDGD1XbG9hXWzmfL7zyu/DaX0fYCi2WWa1Oi+AFT0aNyi3 CKb0sxctn+8K3mUILhDuoAv8xvOFq3Z8wD8NWC+k4sYZB3EnC/kdxQ5S3Feo7lqoCc/N U2V+dJrcSxuYQ2womTf4h2b/GAoGd7Ryga/lsqs1IDxkztE1h8yeGz4Lh/xaJNAgYnuM MfGWDlYapVbpIixP6VTYD1hnO5x+QPnFAKrWAoJjl1pBlBo2YqR43hh5d8IvNHqRAR5g F7Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783682748; x=1784287548; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GnpNr4qDyHoNfCA9ul8yyjujzs6stkD93LOWV1wBtX4=; b=swyesOOXjqb4YVgWPLZSiK+jSHM6obHis9XLm87XwuDJI0/dDgEeeEyOIwwbTlhGLM TWWsmcCAmfSfMdwGElQMixNn3oNZlvBWR214EPEYMfS7t6etgJw13GTg47KNcYz+skJG oEEHuPeezB0RRarro5oTDlFtZXZf87uHFU8MQioKNOMJEJ3lGo7hzTLgxBOXoKIOz0XL 9EbPpEnRvjykRO8rcRBS0u4/cS+7XTyWuLk/CU1DV2/gsZO3MALVp3tXfu2ffISJDjY/ qX3Y4hrGX0SuVr5CcmoCkGJ6GSOUaLqx6nb+bGfEop0nMvAXhs7uHakL74K9NrUNEGcQ hjFA== X-Forwarded-Encrypted: i=1; AHgh+RqU+rSO2W8JbvQkHqJG3Sr98t3Rlpyp0ap/UyIZ4Dm07frfKsADWGzurbLN2BDm+sXwZV2bhwI=@vger.kernel.org X-Gm-Message-State: AOJu0YzoqUdn0sKoHI3YQPn9awsB722oRhklMbnUdqayXtiRWZk4RhAN 9y82RPLTRZehIPSkzhd9bptEjTJ7qysdso3AeGLWrN7HsdH+lHthe8IdyC+uWx3AB1t0IJlPvaV kbGgLNTZJHC+RQLALJyCWDdiiTPhI2KFnmGcaakEIEq86f8VETqpuljfDWg== X-Gm-Gg: AfdE7ckMqxyvUnZI761ATfr94sjeVlMhhllxId5Kwu2T/yvjW6OR0beN1eVhBmEHqBW 4oar1+S04RtkmELqfgKi51zYU6jln19IGUvT+qunXAGMwzEEr/68x+MzBEorZa8OmL/x4iSUnlk yalPihTLpso6aY1RE/UXBcdjDAAZKCeEjw/TJp1ruwfIsB3nVu/Zu3L0DSGj7f3X/aNQzsfN4Zj yMkuaV4HDFZ0HQiceg0ftJQyFw5tgwrQckHeLPoHTWxF7KRc506+4ZMrCwUPPJNB7Os7cfEsAk3 1jqsEo8BknfBuwL1GZsE2dmvg/Tek5CbosL58yQqwSIKLkFxvpSz3sGn6PNQ7sP7ywDMpiiF0VC Jx0cJBnlOUvZ3zeUDT5S4q9fZiqE38JBIr0ijYjrLtGN62thhg9Ye1m3cFr8ksMoA5uzWNtGXWs xrRTAB09YRcPOd X-Received: by 2002:a05:600c:3115:b0:493:b4a3:5ab0 with SMTP id 5b1f17b1804b1-493f2b3fe2amr28786255e9.13.1783682747893; Fri, 10 Jul 2026 04:25:47 -0700 (PDT) X-Received: by 2002:a05:600c:3115:b0:493:b4a3:5ab0 with SMTP id 5b1f17b1804b1-493f2b3fe2amr28785735e9.13.1783682747323; Fri, 10 Jul 2026 04:25:47 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:58fd:68f:7756:389d? ([2a0d:3344:5521:6b10:58fd:68f:7756:389d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6d4f9fsm131494035e9.4.2026.07.10.04.25.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 04:25:46 -0700 (PDT) Message-ID: <9e4e455b-c10b-447e-9fe6-80672f26fd8a@redhat.com> Date: Fri, 10 Jul 2026 13:25:45 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] net/mlx5: free mlx5_st_idx_data on final dealloc To: Zhiping Zhang , Jason Gunthorpe , Leon Romanovsky , Saeed Mahameed Michael , Tariq Toukan , Mark Bloch Cc: Michael Guralnik , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260702222507.1234467-1-zhipingz@meta.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260702222507.1234467-1-zhipingz@meta.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/3/26 12:24 AM, Zhiping Zhang wrote: > Workloads that repeatedly allocate and release mkeys carrying TPH > steering-tag hints (e.g. churning RDMA MRs) leak one > struct mlx5_st_idx_data per cycle; kmemleak flags it as unreferenced > and the kmalloc slab grows over time. > > When the last reference to an ST table entry is dropped, > mlx5_st_dealloc_index() removed the entry from idx_xa but the backing > mlx5_st_idx_data allocation was never freed. > > Free idx_data after the xa_erase() so the lifetime of the bookkeeping > struct matches the lifetime of the ST entry it tracks. > > Cc: stable@vger.kernel.org > Fixes: 888a7776f4fb ("net/mlx5: Add support for device steering tag") > Reviewed-by: Michael Gur > Signed-off-by: Zhiping Zhang @Leon, @Saeed, @Tariq: just in case this fell under the radar, it's waiting for your ack. Thanks, Paolo