From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arkadi Sharshevsky Subject: Re: [patch net-next v2 00/10] Add support for resource abstraction Date: Thu, 4 Jan 2018 02:07:15 +0200 Message-ID: <9e5f043a-3838-cb6f-d14d-10321379c17d@mellanox.com> References: <20171226112359.5313-1-jiri@resnulli.us> <977652df-a0ed-d1a5-f299-1dc433ebd337@mellanox.com> <96389ae0-e038-8a26-84ea-0cf1b9fa0a05@cumulusnetworks.com> <0f861e90-63d3-2666-ef2d-0fc91beae957@mellanox.com> <2f0f6007-64a1-0d0d-eff2-2e5ba6fdb701@cumulusnetworks.com> <20180103181744.GE2067@nanopsycho.orion> <49c72225-6437-54d5-a046-96fff5b65ce9@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com, davem@davemloft.net, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, ast@kernel.org, daniel@iogearbox.net, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, alexander.h.duyck@intel.com, linville@tuxdriver.com, gospo@broadcom.com, steven.lin1@broadcom.com, yuvalm@mellanox.com, ogerlitz@mellanox.com To: David Ahern , Jiri Pirko Return-path: Received: from mail-eopbgr50071.outbound.protection.outlook.com ([40.107.5.71]:14859 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751014AbeADAH3 (ORCPT ); Wed, 3 Jan 2018 19:07:29 -0500 In-Reply-To: <49c72225-6437-54d5-a046-96fff5b65ce9@cumulusnetworks.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 01/03/2018 08:29 PM, David Ahern wrote: > On 1/3/18 11:17 AM, Jiri Pirko wrote: >> Wed, Jan 03, 2018 at 07:14:16PM CET, dsa@cumulusnetworks.com wrote: >>> On 1/3/18 11:05 AM, Arkadi Sharshevsky wrote: >>>> As I stated this is a user-space bug which I fixed, and updated my repo >>>> so please pull. Devlink uses mnl,and currently mnl does not support >>>> extended ack. I added support for this in my local ver of libmnl: >>>> >>>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Farkadis%2Flibmnl.git&data=02%7C01%7Carkadis%40mellanox.com%7C5c86b6240eb84459c6ae08d552d7f9a4%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636506009929977440&sdata=sgrNzMhPwe63BIVxexZTjl%2FXqW51kpuRiHVhTDNaa70%3D&reserved=0 >>>> >>>> On branch master, so you can check it out. Besides this bugs, which were >>>> userspace, can please specify what are the pending problems from your >>>> point of view? Thanks! >>> >>> devlink is in iproute2 package and it has extack support. See 'git log >>> lib/libnetlink.c' >> >> Dave, devlink uses libmnl. >> > > Now I remember. You wrote it independently and but needed iproute2 be a > delivery vehicle. It uses none of the common infrastructure from > iproute2. Could we make this more difficult .... > > Sometime in the next day I will jump through the hoops to get a proper > devlink command. > This actually was very confusing, I think the extack should be handled by libmnl and iproute should use mnl_cb_run() routines and not to implement its own. That way we could both benefit from that. You actually do use libmnl in libnetlink.c only for parsing the headers, and its a dependency for extack handling. I see this as a completely independent user space issue, which doesn't have to do anything with this patchset. Not to mention that everything is working right now.