* [PATCH v2 7/7] net: stmmac: dwmac-s32cc: Read PTP clock rate when ready
@ 2024-08-18 21:52 Jan Petrous (OSS)
2024-08-20 21:17 ` Jacob Keller
0 siblings, 1 reply; 2+ messages in thread
From: Jan Petrous (OSS) @ 2024-08-18 21:52 UTC (permalink / raw)
To: Jan Petrous (OSS), David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Vinod Koul,
Andrew Lunn, Heiner Kallweit, Russell King, Richard Cochran,
Giuseppe Cavallaro
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, dl-S32
The PTP clock is read by stmmac_platform during DT parse.
On S32G/R the clock is not ready and returns 0. Postpone
reading of the clock on PTP init.
Co-developed-by: Andrei Botila <andrei.botila@nxp.org>
Signed-off-by: Andrei Botila <andrei.botila@nxp.org>
Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-s32cc.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-s32cc.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-s32cc.c
index 8daa01d01f29..92c51005cbed 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-s32cc.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-s32cc.c
@@ -149,6 +149,18 @@ static void s32cc_fix_mac_speed(void *priv, unsigned int speed, unsigned int mod
dev_err(gmac->dev, "Can't set tx clock\n");
}
+static void s32cc_gmac_ptp_clk_freq_config(struct stmmac_priv *priv)
+{
+ struct plat_stmmacenet_data *plat = priv->plat;
+
+ if (!plat->clk_ptp_ref)
+ return;
+
+ plat->clk_ptp_rate = clk_get_rate(plat->clk_ptp_ref);
+
+ netdev_dbg(priv->dev, "PTP rate %lu\n", plat->clk_ptp_rate);
+}
+
static int s32cc_dwmac_probe(struct platform_device *pdev)
{
struct plat_stmmacenet_data *plat;
@@ -204,6 +216,7 @@ static int s32cc_dwmac_probe(struct platform_device *pdev)
plat->init = s32cc_gmac_init;
plat->exit = s32cc_gmac_exit;
plat->fix_mac_speed = s32cc_fix_mac_speed;
+ plat->ptp_clk_freq_config = s32cc_gmac_ptp_clk_freq_config;
plat->bsp_priv = gmac;
--
2.46.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 7/7] net: stmmac: dwmac-s32cc: Read PTP clock rate when ready
2024-08-18 21:52 [PATCH v2 7/7] net: stmmac: dwmac-s32cc: Read PTP clock rate when ready Jan Petrous (OSS)
@ 2024-08-20 21:17 ` Jacob Keller
0 siblings, 0 replies; 2+ messages in thread
From: Jacob Keller @ 2024-08-20 21:17 UTC (permalink / raw)
To: Jan Petrous (OSS), David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Vinod Koul,
Andrew Lunn, Heiner Kallweit, Russell King, Richard Cochran,
Giuseppe Cavallaro
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, dl-S32
On 8/18/2024 2:52 PM, Jan Petrous (OSS) wrote:
> The PTP clock is read by stmmac_platform during DT parse.
> On S32G/R the clock is not ready and returns 0. Postpone
> reading of the clock on PTP init.
>
Ah, I see. So the clock returns zero into the hardware bits accessed by
stmmac_platform. Then you come back in and fill this in later during the
dwmac_probe.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-20 21:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-18 21:52 [PATCH v2 7/7] net: stmmac: dwmac-s32cc: Read PTP clock rate when ready Jan Petrous (OSS)
2024-08-20 21:17 ` Jacob Keller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).