From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1B44801 for ; Thu, 16 May 2024 16:31:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715877079; cv=none; b=LQf95fVTaIrGRSnDMVMk9lwvhExYQsXNQxjGSW8y5uPNA/72ufvOyph5s/S8o1MQ8YDo6LAwimLJC9Sj23g8Xl9TAVOALcCZpmVngf7I1nPT6nFjfbKqmRoDJ3hx5OFHW4iKzsGrDpGXZSl6G26yHYqtfirGJAJgIdlXYp6oHK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715877079; c=relaxed/simple; bh=xkfznAhSXPPgMUvz2RZcB9OT2Zux0dt6kJDr+ShFPrA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TLn4wxdc3RG/1FZVUXwDD5F1lIhUNrrYYB1UVBC23F/ZIWFDb1A9kKeGp25YNJy1/1zu3Wq18UDIHykwLjE0bh3pSw+ju30ePOrTO5UXcg1fydPO5gUU5jkqXghxH7E0jXZTuqSnEJ6ObGmTOUelarXNrH0J4AlU7YMeL1bX1UY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TGZ+rhCh; arc=none smtp.client-ip=209.85.166.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TGZ+rhCh" Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-7e1fb2a81fdso5728939f.1 for ; Thu, 16 May 2024 09:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1715877076; x=1716481876; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pDnoiv+aAilJOglosMLJSLeZ15PVLhndVRN5KP2yh64=; b=TGZ+rhChyRj5oWtecIQsAYYU5joL5ZarwVOJkKi6LVVn1xVoi0hSNjEtIObQLT8hdM WIx5VkA6oEqMxG6aR2Yw7bwo1q4jd2ADzaHp2AXIyzKhZO4n3mtUjsfANJL7Et5QhgEA 8kIUJIrRB90zzkeSDU1NGARAEQHe6sXTJsed8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715877076; x=1716481876; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pDnoiv+aAilJOglosMLJSLeZ15PVLhndVRN5KP2yh64=; b=XzQDgOyTZMS13htBfCWqUiFQouHo0Q/bWrusH2TKaLCiZGSbBAAQtB90xcwpyd7I79 OvQfZbn+fSnvAWziGZH+fDo+MhA1Mz8IFYHIJX2L0aauEN0fIkKsw+M16JGtvjvUfsl9 e+7UR8R/AFsQvdaGsqU/CGQz7tOcLbsBKRMMXFF0Dzit5aGykYMnn9WEAfCEhQqUorC+ zIuj5mANwucwIhP59NOzV8mZeO938HtTjnFFwXgXoy/IoAJ7KYbIko561TW12LJ90bO3 qWYIt0gX+QnomTnBGvjSGIYZ3dhEYErjUvOK0dfrEBJZpZtwpJpZHkXgeuCUoGC7Y85e RIrA== X-Forwarded-Encrypted: i=1; AJvYcCXR4zt39H+xFc9/VC/cr6q1Tiu9RdopQjWS1aXQENfmJBizkwzC0fJPzsLUPdyrCwN+vU+PORA+o+r+ngZE8rDJBG0bBMXo X-Gm-Message-State: AOJu0Yyw95OPvBfXH2npd9PbZRafyPhgkxFJgW3iAZaouVVdyoqp5ix5 Yfxf+JTMyoxvbTdv6psS5Xi1Wz6luqcjDDrUZSxOUl5VpVTAXhT8iKrPawYoS08= X-Google-Smtp-Source: AGHT+IHC7NWHiVtGdW49HXEWLPpD9poqjpxpz8h5HFbktLyqnUrR9q12B55ixwuwmtZx24K1zeLkFg== X-Received: by 2002:a05:6e02:1c8b:b0:36c:c599:698a with SMTP id e9e14a558f8ab-36cc599af7dmr211295495ab.2.1715877075869; Thu, 16 May 2024 09:31:15 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-36dbbd191b0sm7514315ab.17.2024.05.16.09.31.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 May 2024 09:31:15 -0700 (PDT) Message-ID: <9e72d97a-9a04-4423-a711-0c21c1c8b161@linuxfoundation.org> Date: Thu, 16 May 2024 10:31:13 -0600 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE To: Tejun Heo Cc: Edward Liaw , shuah@kernel.org, =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , =?UTF-8?Q?G=C3=BCnther_Noack?= , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Zefan Li , Johannes Weiner , Muchun Song , Michal Hocko , Roman Gushchin , Shakeel Butt , Yosry Ahmed , Nhat Pham , Chengming Zhou , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Shuah Khan References: <20240510000842.410729-1-edliaw@google.com> <20240510000842.410729-9-edliaw@google.com> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/16/24 10:21, Tejun Heo wrote: > On Thu, May 16, 2024 at 09:50:06AM -0600, Shuah Khan wrote: >> On 5/13/24 11:02, Tejun Heo wrote: >>> On Fri, May 10, 2024 at 12:06:25AM +0000, Edward Liaw wrote: >>>> _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent >>>> redefinition warnings. >>>> >>>> Signed-off-by: Edward Liaw >>> >>> Applied to cgroup/for-6.10. >>> >>> Thanks. >>> >> >> Hi Tejun, >> >> Please don't include this in your PR to Linus. This patch series needs >> to go together as it is causing several build warns and some errors. > > I'm afraid it's too late. The PR is too late. Do you want me to send an > amended PR with the commit reverted? If it's just temporary issues in > selftests, maybe we can just wait it out? > I am exploring options and leaning towards reverting the patch daef47b89efd ("selftests: Compile kselftest headers with -D_GNU_SOURCE") Your amending the PR helps me if I have to send revert. I am sorry for the trouble. I can all of them together in a second update or after the merge window closes. thanks, -- Shuah