netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: PA Semi PWRficient Gigabit Ethernet doesn't work anymore since the first networking updates for the kernel 4.16
Date: Sun, 4 Feb 2018 17:47:03 +0100	[thread overview]
Message-ID: <9e8e906d-b2b7-f11c-30ed-ccdf91ac563c@xenosoft.de> (raw)
In-Reply-To: <20180119132251.GJ32299@lunn.ch>

[-- Attachment #1: Type: text/plain, Size: 1851 bytes --]

Hello,

The PA Semi PWRficient Gigabit Ethernet doesn't work anymore since the 
first networking updates [1] for the kernel 4.16.

Error messages:

[    0.634241] libphy: pasemi gpio mdio bus: probed
[    0.634749] pasemi gpio mdio bus: Cannot register as MDIO bus, err -38
[    2.311496] pasemi_mac 0000:00:14.0: runtime IRQ mapping not provided 
by arch
[    2.311554] pasemi_mac 0000:00:14.1: runtime IRQ mapping not provided 
by arch
[    2.311599] pasemi_mac 0000:00:14.2: runtime IRQ mapping not provided 
by arch
[    2.311641] pasemi_mac 0000:00:14.3: runtime IRQ mapping not provided 
by arch
[    2.312276] pasemi_mac 0000:00:15.0: runtime IRQ mapping not provided 
by arch
[    2.312903] pasemi_mac 0000:00:15.1: runtime IRQ mapping not provided 
by arch
[    3.817420] i2c-pasemi 0000:00:1c.0: runtime IRQ mapping not provided 
by arch
[    3.817616] i2c-pasemi 0000:00:1c.1: runtime IRQ mapping not provided 
by arch
[    3.817809] i2c-pasemi 0000:00:1c.2: runtime IRQ mapping not provided 
by arch
[    4.299984] pasemi_edac 0000:00:04.0: runtime IRQ mapping not 
provided by arch
[    4.300281] pasemi_edac 0000:00:05.0: runtime IRQ mapping not 
provided by arch
[   39.633565] pasemi_mac 0000:00:14.3: PHY init failed: -19.
[   39.633569] pasemi_mac 0000:00:14.3: Defaulting to 1Gbit full duplex

I figured out that the problematic code is in the mdio bus changes of 
the networking updates. [1]

I found the problematic code in the file 'drivers/net/phy/mdio_bus.c'. I 
created a patch which solves the problem with the PA Semi PWRficient 
Gigabit Ethernet. (attached)

Could you please check the changes in the file 'drivers/net/phy/mdio_bus.c'?

Thanks,
Christian

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b2fe5fa68642860e7de76167c3111623aa0d5de1

[-- Attachment #2: mdio_bus.patch --]
[-- Type: text/x-patch, Size: 1052 bytes --]

--- a/drivers/net/phy/mdio_bus.c	2018-02-03 17:34:46.973045321 +0100
+++ b/drivers/net/phy/mdio_bus.c	2018-02-04 11:03:14.909093360 +0100
@@ -47,41 +47,11 @@
 
 #include "mdio-boardinfo.h"
 
-static int mdiobus_register_gpiod(struct mdio_device *mdiodev)
-{
-	struct gpio_desc *gpiod = NULL;
-
-	/* Deassert the optional reset signal */
-	if (mdiodev->dev.of_node)
-		gpiod = fwnode_get_named_gpiod(&mdiodev->dev.of_node->fwnode,
-					       "reset-gpios", 0, GPIOD_OUT_LOW,
-					       "PHY reset");
-	if (PTR_ERR(gpiod) == -ENOENT)
-		gpiod = NULL;
-	else if (IS_ERR(gpiod))
-		return PTR_ERR(gpiod);
-
-	mdiodev->reset = gpiod;
-
-	/* Assert the reset signal again */
-	mdio_device_reset(mdiodev, 1);
-
-	return 0;
-}
-
 int mdiobus_register_device(struct mdio_device *mdiodev)
 {
-	int err;
-
 	if (mdiodev->bus->mdio_map[mdiodev->addr])
 		return -EBUSY;
 
-	if (mdiodev->flags & MDIO_DEVICE_FLAG_PHY) {
-		err = mdiobus_register_gpiod(mdiodev);
-		if (err)
-			return err;
-	}
-
 	mdiodev->bus->mdio_map[mdiodev->addr] = mdiodev;
 
 	return 0;

  parent reply	other threads:[~2018-02-04 16:47 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAHkrCmFCzPd_a1UmyfuZHKM4hXvou0uO0FYoG5bd_fxE8QMueg@mail.gmail.com>
2018-01-15 16:38 ` DPAA Ethernet traffice troubles with Linux kernel Madalin-cristian Bucur
2018-01-15 16:59   ` Joakim Tjernlund
2018-01-15 19:03     ` Christian Zigotzky
2018-01-15 19:09       ` Christian Zigotzky
2018-01-15 20:21         ` mad skateman
2018-01-15 21:32         ` mad skateman
2018-01-16 15:04           ` Andrew Lunn
2018-01-16 17:07             ` Madalin-cristian Bucur
2018-01-16 14:38     ` Andrew Lunn
2018-01-16 17:57       ` Joakim Tjernlund
2018-01-16 18:16         ` mad skateman
2018-01-16 18:38         ` mad skateman
2018-01-16 18:39         ` mad skateman
2018-01-17  5:54           ` Christian Zigotzky
     [not found]             ` <ABA45EE3-92E3-4706-90F9-516E227646E2@xenosoft.de>
2018-01-17  7:22               ` Christian Zigotzky
2018-01-16 20:53         ` Andrew Lunn
2018-01-17 11:47           ` Joakim Tjernlund
2018-01-17 12:06             ` mad skateman
2018-01-17 13:43             ` Andrew Lunn
2018-01-17 14:15               ` Madalin-cristian Bucur
2018-01-17 14:24                 ` Madalin-cristian Bucur
2018-01-17 14:43                   ` Madalin-cristian Bucur
2018-01-17 14:11         ` Madalin-cristian Bucur
2018-01-17 15:00           ` Joakim Tjernlund
2018-01-18  9:04             ` Joakim Tjernlund
2018-01-19  8:00           ` Joakim Tjernlund
2018-01-19 13:22             ` Andrew Lunn
2018-01-19 13:42               ` Joakim Tjernlund
2018-02-04 16:47               ` Christian Zigotzky [this message]
2018-02-04 17:16                 ` PA Semi PWRficient Gigabit Ethernet doesn't work anymore since the first networking updates for the kernel 4.16 Andrew Lunn
2018-02-04 20:01                   ` Florian Fainelli
2018-02-05  9:38                   ` Christian Zigotzky
2018-02-05 14:29                     ` Andrew Lunn
2018-02-05 15:27                       ` Christian Zigotzky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e8e906d-b2b7-f11c-30ed-ccdf91ac563c@xenosoft.de \
    --to=chzigotzky@xenosoft.de \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).