Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: dpll: Fix compilation warning

[Przemek Kitszel <przemyslaw.kitszel@intel.com>]

On 2/23/26 15:31, Przemyslaw Korba wrote:
> ice_dpll.c: In function ‘ice_dpll_init’:
> ice_dpll.c:3588:59: error: ‘%u’ directive output may be truncated
> writing between 1 and 10 bytes into a region of size 4
> [-Werror=format-truncation=] snprintf(pin_name, sizeof(pin_name),
> "rclk%u", i);
> 
> Fixes: ad1df4f2d591 ("ice: dpll: Support E825-C SyncE and dynamic pin discovery")

thank you for the fix
this is a correct tag, and a correct target

> Signed-off-by: Przemyslaw Korba <przemyslaw.korba@intel.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_dpll.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.c b/drivers/net/ethernet/intel/ice/ice_dpll.c
> index 73a4e28ed75f..f101fdb3e9cf 100644
> --- a/drivers/net/ethernet/intel/ice/ice_dpll.c
> +++ b/drivers/net/ethernet/intel/ice/ice_dpll.c
> @@ -3532,7 +3532,7 @@ static int
>   ice_dpll_init_fwnode_pins(struct ice_pf *pf, struct ice_dpll_pin *pins,
>   			  int start_idx)
>   {
> -	char pin_name[8];
> +	char pin_name[16];
>   	int i, ret;
>   
>   	pf->dplls.wq = create_singlethread_workqueue("ice_dpll_wq");

3537│         for (i = 0; i < pf->dplls.rclk.num_parents; i++) {

upper bound of the loop is u8 (ok), but we assign it as an int (good)

3538│                 pins[start_idx + i].pf = pf;
3539│                 snprintf(pin_name, sizeof(pin_name), "rclk%u", i);

compiler tries to be too smart here


anyway, it's better to have that warning gone instead of waiting for
a fix in the compiler

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>