From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] net: amd: add of_node_put() Date: Thu, 22 Nov 2018 11:28:21 +0300 Message-ID: <9ec3ef0c-b931-6a1e-e1ed-5538c42df830@cogentembedded.com> References: <20181121125824.22168-1-tiny.windzz@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Yangtao Li , davem@davemloft.net, yuehaibing@huawei.com Return-path: In-Reply-To: <20181121125824.22168-1-tiny.windzz@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello! On 21.11.2018 15:58, Yangtao Li wrote: > of_find_node_by_path() acquires a reference to the node > returned by it and that reference needs to be dropped by its caller. > bl_idle_init() doesn't do that, so fix it. Again, maybe sparc_lance_probe_one() doesn't do that? > Signed-off-by: Yangtao Li > --- > drivers/net/ethernet/amd/sunlance.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/amd/sunlance.c b/drivers/net/ethernet/amd/sunlance.c > index b4fc0ed5bce8..9d4899826823 100644 > --- a/drivers/net/ethernet/amd/sunlance.c > +++ b/drivers/net/ethernet/amd/sunlance.c > @@ -1419,7 +1419,7 @@ static int sparc_lance_probe_one(struct platform_device *op, > > prop = of_get_property(nd, "tpe-link-test?", NULL); > if (!prop) > - goto no_link_test; > + goto node_put; > > if (strcmp(prop, "true")) { > printk(KERN_NOTICE "SunLance: warning: overriding option " > @@ -1428,6 +1428,8 @@ static int sparc_lance_probe_one(struct platform_device *op, > "to ecd@skynet.be\n"); > auxio_set_lte(AUXIO_LTE_ON); > } > +node_put: > + of_node_put(nd); > no_link_test: > lp->auto_select = 1; > lp->tpe = 0; MBR, Sergei