From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net] rxrpc: Fix incorrect conditional on IPV6 Date: Fri, 12 Oct 2018 08:19:20 -0700 Message-ID: <9ee1a767-b865-6afa-91a2-311422b8338d@gmail.com> References: <153935592320.3029.14678717675993366.stgit@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Arnd Bergmann , netdev@vger.kernel.org, linux-afs@lists.infradead.org To: David Howells Return-path: Received: from mail-pg1-f174.google.com ([209.85.215.174]:46973 "EHLO mail-pg1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728182AbeJLWwS (ORCPT ); Fri, 12 Oct 2018 18:52:18 -0400 Received: by mail-pg1-f174.google.com with SMTP id a5-v6so5979997pgv.13 for ; Fri, 12 Oct 2018 08:19:22 -0700 (PDT) In-Reply-To: <153935592320.3029.14678717675993366.stgit@warthog.procyon.org.uk> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/12/2018 07:52 AM, David Howells wrote: > The udpv6_encap_enable() function is part of the ipv6 code, and if that is > configured as a loadable module and rxrpc is built in then a build failure > will occur because the conditional check is wrong: > > net/rxrpc/local_object.o: In function `rxrpc_lookup_local': > local_object.c:(.text+0x2688): undefined reference to `udpv6_encap_enable' > > Use the correct config symbol (CONFIG_AF_RXRPC_IPV6) in the conditional > check rather than CONFIG_IPV6 as that will do the right thing. > > Fixes: 5271953cad31 ("rxrpc: Use the UDP encap_rcv hook") > Signed-off-by: David Howells > cc: Arnd Bergmann Nit : Correct attribution would require a Reported-by: tag