From: Paolo Abeni <pabeni@redhat.com>
To: Jason Xing <kerneljasonxing@gmail.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
bjorn@kernel.org, magnus.karlsson@intel.com,
maciej.fijalkowski@intel.com, jonathan.lemon@gmail.com,
sdf@fomichev.me, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next v6 2/2] xsk: move cq_cached_prod_lock to avoid touching a cacheline in sending path
Date: Thu, 8 Jan 2026 09:55:07 +0100 [thread overview]
Message-ID: <9f0fffcd-8e2a-4ae1-b89d-ae73dba9e1be@redhat.com> (raw)
In-Reply-To: <20260104012125.44003-3-kerneljasonxing@gmail.com>
On 1/4/26 2:21 AM, Jason Xing wrote:
> diff --git a/net/xdp/xsk_buff_pool.c b/net/xdp/xsk_buff_pool.c
> index 6bf84316e2ad..cd5125b6af53 100644
> --- a/net/xdp/xsk_buff_pool.c
> +++ b/net/xdp/xsk_buff_pool.c
> @@ -91,7 +91,7 @@ struct xsk_buff_pool *xp_create_and_assign_umem(struct xdp_sock *xs,
> INIT_LIST_HEAD(&pool->xsk_tx_list);
> spin_lock_init(&pool->xsk_tx_list_lock);
> spin_lock_init(&pool->cq_prod_lock);
> - spin_lock_init(&pool->cq_cached_prod_lock);
> + spin_lock_init(&xs->cq_tmp->cq_cached_prod_lock);
> refcount_set(&pool->users, 1);
Very minor nit: moving the init later, after:
pool->cq = xs->cq_tmp;
would avoid touching a '_tmp' field, which looks strange.
Please do not resubmit just for this. Waiting a little longer for
Magnus, Maciej or Stanislav ack.
/P
next prev parent reply other threads:[~2026-01-08 8:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 1:21 [PATCH net-next v6 0/2] xsk: move cq_cached_prod_lock Jason Xing
2026-01-04 1:21 ` [PATCH net-next v6 1/2] xsk: advance cq/fq check when shared umem is used Jason Xing
2026-01-04 1:21 ` [PATCH net-next v6 2/2] xsk: move cq_cached_prod_lock to avoid touching a cacheline in sending path Jason Xing
2026-01-08 8:55 ` Paolo Abeni [this message]
2026-01-08 9:07 ` Jason Xing
2026-01-13 5:33 ` Jason Xing
2026-01-14 20:57 ` Stanislav Fomichev
2026-01-14 20:56 ` [PATCH net-next v6 0/2] xsk: move cq_cached_prod_lock Stanislav Fomichev
2026-01-15 9:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f0fffcd-8e2a-4ae1-b89d-ae73dba9e1be@redhat.com \
--to=pabeni@redhat.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox