From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0E72C282C0 for ; Fri, 25 Jan 2019 17:12:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71B49218B0 for ; Fri, 25 Jan 2019 17:12:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qgvcV4HE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726523AbfAYRMZ (ORCPT ); Fri, 25 Jan 2019 12:12:25 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:35260 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726311AbfAYRMY (ORCPT ); Fri, 25 Jan 2019 12:12:24 -0500 Received: by mail-pg1-f195.google.com with SMTP id s198so4462843pgs.2 for ; Fri, 25 Jan 2019 09:12:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5gCm1xq+vO0avOIR3n0doLdV4nq6RhUGIRAwKbFoEwE=; b=qgvcV4HEdxR9GH5Ds6MUaoryjB18yde06ImTXDTg6p+hzWGb/+d+WlYh7MOw+vUZa4 k6p2DFPekVfXAxIafcVGJETx2FPAdfVuTikcC5t/HsDKm2l7FX1s0r6olEmLQbXywekM ULT00eluPv6adqSI36jSaHXsfi6FJI1MrbqMMHqaBAC7fBmJ0BpFsw6CVzdRaJ7HNYYk CXoitLftFSFfAPWGFHphzAkZIApjpmoT/vIvXSjXXxB7tDgKKOUi1cGfRz5ANf1kdYZc 8MHL9LdD1ePAS4lihJrv+I3SSqIIR/nwDexBBNuPnZpXkAjT/lj7RZgpseXSFD0IMPRm A17w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5gCm1xq+vO0avOIR3n0doLdV4nq6RhUGIRAwKbFoEwE=; b=OYX+ZzhdtB6O/Jo3ZyO4dqUxXg7YlH2UlakkA6pHoKHI6de/Q/0xXJdwm6i1ymjCTK IBgNxqIlc65om0JVnNBgvL5nr/rULheH7/vIJdjGRfk70rBBltL+4Vqligjwoaolru4k iG4SRQERYzgCIRI692jeqFU6JzDEcr7dpoBEHWPGtNZbR2J4HaOYssHGGUjTZxMibZfw xhGuMrlRtUlQ0RWIiVAigsxUqjeW9Z6EKbsuseVuRIJVsof/67rmnlbB5o7lnaf70HQH TT7b5CgnKg3yu35GhDKBPIXS7KEqMR4UDhFlcfgR9jBqWbljHaxrc9TLU3Ug97BU9yvV tp0g== X-Gm-Message-State: AJcUukfukE+YtV5bsSO0aUnQNtKslPryrGFozr3TJUXXzlrrCBm4u3t5 OOQTglMnUeyqCvm8KeV3SuM= X-Google-Smtp-Source: ALg8bN5mFlhZh8STcDL/T1fMImktGt4yjt3rxp4jnbY5rVTggk0SGqzZi4p6nHqebcbcgZfZaG+q/g== X-Received: by 2002:a63:1766:: with SMTP id 38mr10485725pgx.299.1548436343389; Fri, 25 Jan 2019 09:12:23 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:795a:c9ad:c0d4:74ef? ([2601:282:800:fd80:795a:c9ad:c0d4:74ef]) by smtp.googlemail.com with ESMTPSA id e24sm31268025pfi.153.2019.01.25.09.12.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Jan 2019 09:12:22 -0800 (PST) Subject: Re: [PATCH iproute2-master] bridge: fdb: Fix FDB dump with strict checking disabled To: Ido Schimmel , "netdev@vger.kernel.org" Cc: "stephen@networkplumber.org" , "ivecera@redhat.com" , "liali@redhat.com" , mlxsw References: <20190125170837.6434-1-idosch@mellanox.com> From: David Ahern Message-ID: <9f1514e2-132b-f0f8-b3d5-dcb52dbc91bb@gmail.com> Date: Fri, 25 Jan 2019 10:12:21 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190125170837.6434-1-idosch@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/25/19 10:09 AM, Ido Schimmel wrote: > While iproute2 correctly uses ifinfomsg struct as the ancillary header > when requesting an FDB dump on old kernels, it sets the message type to > RTM_GETLINK. This results in wrong reply being returned. > > Fix this by using RTM_GETNEIGH instead. > > Before: > $ bridge fdb show brport dummy0 > Not RTM_NEWNEIGH: 00000158 00000010 00000002 > > After: > $ bridge fdb show brport dummy0 > 2a:0b:41:1c:92:d3 vlan 1 master br0 permanent > 2a:0b:41:1c:92:d3 master br0 permanent > 33:33:00:00:00:01 self permanent > 01:00:5e:00:00:01 self permanent > > Fixes: 05880354c2cf ("bridge: fdb: Fix filtering with strict checking disabled") > Signed-off-by: Ido Schimmel > Reported-by: LiLiang > --- > bridge/fdb.c | 3 +-- > include/libnetlink.h | 3 +++ > lib/libnetlink.c | 23 +++++++++++++++++++++++ > 3 files changed, 27 insertions(+), 2 deletions(-) > Acked-by: David Ahern