Re: [PATCH net v2] net: stmmac: resume PHY before hardware setup when opening the interface

[Stefan Agner <stefan@agner.ch>]

Hi Jakub,

On 2026-07-07 23:13, Jakub Raczynski wrote:
> Please read
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
> in this case 'don’t repost your patches within one 24h period'
> 
> Because:
> - you have two patches now processing and no changes requested yet,
>   nor did you get AI review that is currently employed
>   https://patchwork.kernel.org/project/netdevbpf/patch/20260707195425.405989-1-stefan@agner.ch/
>   and
>   https://patchwork.kernel.org/project/netdevbpf/patch/20260707162146.73823-1-stefan@agner.ch/

Isn't the definition of "repost" the same patch?

I took Andrew Lunn's comment as a change request, hence v2...

> - This change is actually broken - in previous patch rtnl_lock() was asserted
>   by dev_ioctl(), but in this version it is not asserted anywhere and will
>   trigger WARN_ONCE().
> - Full tests within an hour is possible, but no need to rush patches
> - Please spend time reviewing patches, as I spent few minutes to make sure
>   you (or rather Fable AI) is correct that rtnl_lock() was asserted, so my
>   review would be accurate (previous patch was ok, this is not).
> - Please respond yourself to comments, take time to understand codebase.
>   I would prefer not getting copy-paste answer from AI,
>   we have Sashiko review for that.

I am guessing you allude to my response at
https://patchwork.kernel.org/project/netdevbpf/patch/20260707162146.73823-1-stefan@agner.ch/#27051411

Can I influence the prompt for Sashiko? From my point of view the
response was for a specific architectural questions, which needed a
specific prompt to get the answer for. I've clearly declared that I've
used AI to aid for this discussion, is that no allowed?

> - Missing link to previous thread, shown below
> - Moving code to other lines does not justify dropping "Assisted by AI"

Whoops, yeah those two are failure on my part. Sorry about that.

Thanks for your help guiding me through the process! I intend to send
out v3, which at this point looks to be pretty much v2 plus formal fixes
and adding a tested by tag.

--
Stefan