From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8901345CD7 for ; Fri, 14 Nov 2025 18:00:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763143209; cv=none; b=aXNkoha4qowRKKlgstQ2zK7KW/Bjgxm9WrwzRjDvgyJUlCQUjJZ6aKr3nVaEWCmRzykEjjpdskmFKNf+9NOtZz/KDxCWWVB4Zvcw8sl0E1Gv9l/rhQpDEBDZYhzKlw74zSqO+dGU3yXtpMSjRvxIPMKAgT4VKCxFRBGOcT0PKzM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763143209; c=relaxed/simple; bh=ZJX1DmRveCnnf7EP6Rj/m+1FwNvs2kuIwyWt16OrAH4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mrD4UnUTO7Zjos8c8kV2V2eX1gRLhuRSzbAPTcmooYHWYRdtK5jFqkhOznn/bfPj2mb0EDtQx+dsTMFCpAyVagLFcPYdLfYGwCERF1yKwzG78p8N4VKH1okIGbwwo9GwbdGwchVYjVj+maWC30h/n/MPMKEJZgT3qgKoKd+dXzQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XKCWRw13; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XKCWRw13" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FB04C4CEF8; Fri, 14 Nov 2025 18:00:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763143209; bh=ZJX1DmRveCnnf7EP6Rj/m+1FwNvs2kuIwyWt16OrAH4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=XKCWRw13YdKWTKn9ORewry8gXaPuSQuZ3MVdAIGmsdsrN7O1Brc1STm0bBGf2HSBJ Z4YLtUOHxZzhWi1MvTVr/K/KtJKNzQbXpvQEQITq+RvOpFq2yhiyEDgKXr6RPJ4etJ Pq7/GLh7OfH0tRAEGxTBmqEqKXorHSD3LBtuvKtKd3hjQ+W7JzqyGGDoBhfV6J01Q3 SMYwfStz23Uwrw5ChLpFue8z8LWjcpbXBaQCBzixh7Q1i2jQ0g/ykEzYC8zy6ne0Ih zGMJxNsClwLQXXMzCVuymLbKHP3cwejWHL0DbEX4XiZZu2WI/ZX4TCRkkv5SjNv8n4 3dHImQ6rOIrFg== Message-ID: <9f8487ee-be04-4198-9fae-042facbf0883@kernel.org> Date: Fri, 14 Nov 2025 19:00:02 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv4 net-next 3/3] tools: ynl: add YNL test framework Content-Language: en-GB, fr-BE To: Hangbin Liu , netdev@vger.kernel.org Cc: Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jan Stancek , =?UTF-8?Q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= , Stanislav Fomichev , Ido Schimmel , Guillaume Nault , Sabrina Dubroca , Petr Machata References: <20251114034651.22741-1-liuhangbin@gmail.com> <20251114034651.22741-4-liuhangbin@gmail.com> From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <20251114034651.22741-4-liuhangbin@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Hangbin, On 14/11/2025 04:46, Hangbin Liu wrote: > Add a test framework for YAML Netlink (YNL) tools, covering both CLI and > ethtool functionality. The framework includes: > > 1) cli: family listing, netdev, ethtool, rt-* families, and nlctrl > operations > 2) ethtool: device info, statistics, ring/coalesce/pause parameters, and > feature gettings > > The current YNL syntax is a bit obscure, and end users may not always know > how to use it. This test framework provides usage examples and also serves > as a regression test to catch potential breakages caused by future changes. Thank you for the new version! I have two minor comments, up to you to fix that or not. (...) > diff --git a/tools/net/ynl/tests/test_ynl_cli.sh b/tools/net/ynl/tests/test_ynl_cli.sh > new file mode 100755 > index 000000000000..f40eecbb9701 > --- /dev/null > +++ b/tools/net/ynl/tests/test_ynl_cli.sh > @@ -0,0 +1,309 @@ > +#!/bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# Test YNL CLI functionality > + > +# Load KTAP test helpers > +KSELFTEST_KTAP_HELPERS="$(dirname "$(realpath "$0")")/../../../testing/selftests/kselftest/ktap_helpers.sh" > +# shellcheck disable=SC1090 nit: maybe you can use this instead? # shellcheck source=../../../testing/selftests/kselftest/ktap_helpers.sh (If not, it might be good to always document why something is disabled by adding a comment on the same line or before.) (Same for the other test.) (...) > +ktap_print_header > +ktap_set_plan 9 I think you should print the plan after the setup, to avoid this in case of errors during the setup: TAP version 13 1..9 1..0 # SKIP (...) Note that it might be interesting to add a dedicated variable for the tests counter that you increment after having declared each test, just not to forget modifying the plan when a new test is added, e.g. TESTS_NO=0 (...) cli_list_families() { (...) } TESTS_NO=$((TESTS_NO + 1)) (...) # Run all tests ktap_set_plan "${TESTS_NO}" cli_list_families (...) (Same for the other test.) Cheers, Matt -- Sponsored by the NGI0 Core fund.