From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Alexander Lobakin <aleksander.lobakin@intel.com>,
Joe Damato <jdamato@fastly.com>
Cc: <netdev@vger.kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>,
open list <linux-kernel@vger.kernel.org>,
Simon Horman <horms@kernel.org>
Subject: Re: [RFC net-next 1/1] idpf: Don't hard code napi_struct size
Date: Mon, 30 Sep 2024 15:10:41 +0200 [thread overview]
Message-ID: <9f86b27c-8d5c-4df9-8d8c-91edb01b0b79@intel.com> (raw)
In-Reply-To: <c32620a8-2497-432a-8958-b9b59b769498@intel.com>
On 9/30/24 14:38, Alexander Lobakin wrote:
> From: Alexander Lobakin <aleksander.lobakin@intel.com>
> Date: Mon, 30 Sep 2024 14:33:45 +0200
>
>> From: Joe Damato <jdamato@fastly.com>
>> Date: Wed, 25 Sep 2024 18:00:17 +0000
> struct napi_struct doesn't have any such fields and doesn't depend on
> the kernel configuration, that's why it's hardcoded.
> Please don't change that, just adjust the hardcoded values when needed.
This is the crucial point, and I agree with Olek.
If you will find it more readable/future proof, feel free to add
comments like /* napi_struct */ near their "400" part in the hardcode.
Side note: you could just run this as a part of your netdev series,
given you will properly CC.
next prev parent reply other threads:[~2024-09-30 13:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 18:00 [RFC net-next 0/1] idpf: Don't hardcode napi_struct size Joe Damato
2024-09-25 18:00 ` [RFC net-next 1/1] idpf: Don't hard code " Joe Damato
2024-09-25 20:33 ` Simon Horman
2024-09-30 12:33 ` Alexander Lobakin
2024-09-30 12:38 ` Alexander Lobakin
2024-09-30 13:10 ` Przemek Kitszel [this message]
2024-09-30 22:17 ` Joe Damato
2024-10-01 13:14 ` Alexander Lobakin
2024-10-01 14:44 ` Joe Damato
2024-10-02 17:17 ` Jakub Kicinski
2024-10-03 13:35 ` Alexander Lobakin
2024-10-03 15:46 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f86b27c-8d5c-4df9-8d8c-91edb01b0b79@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).