From: Paolo Abeni <pabeni@redhat.com>
To: Antoine Tenart <atenart@kernel.org>,
davem@davemloft.net, kuba@kernel.org, edumazet@google.com
Cc: sd@queasysnail.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: mscc: macsec: do not copy encryption keys
Date: Tue, 15 Nov 2022 15:38:06 +0100 [thread overview]
Message-ID: <9facd5682e29fa5e02062c8f665d9c2370a16fdb.camel@redhat.com> (raw)
In-Reply-To: <20221114092033.34405-1-atenart@kernel.org>
Hello,
On Mon, 2022-11-14 at 10:20 +0100, Antoine Tenart wrote:
> Instead of calling memzero_explicit on the key when freeing a flow,
> let's simply not copy the key in the first place as it's only used when
> a new flow is set up.
>
> Signed-off-by: Antoine Tenart <atenart@kernel.org>
> ---
>
> Following
> https://lore.kernel.org/all/20221108153459.811293-1-atenart@kernel.org/T/
> refactor the MSCC PHY driver not to make a copy the encryption keys.
The patch LGTM, but would you mind including into the commit message a
reference to the -net commit, so that the dependency is there to
simplify eventual backports?
Thanks!
Paolo
next prev parent reply other threads:[~2022-11-15 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 9:20 [PATCH net-next] net: phy: mscc: macsec: do not copy encryption keys Antoine Tenart
2022-11-15 14:38 ` Paolo Abeni [this message]
2022-11-15 14:58 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9facd5682e29fa5e02062c8f665d9c2370a16fdb.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).