From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>, Aaron Ma <aaron.ma@canonical.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Akeem G Abodunrin <akeem.g.abodunrin@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
<intel-wired-lan@lists.osuosl.org>, Kohei Enju <kohei@enjuk.jp>
Subject: Re: [Intel-wired-lan] [PATCH v2] ice: wait for reset completion in ice_resume()
Date: Tue, 28 Apr 2026 15:07:45 +0200 [thread overview]
Message-ID: <9fd9877a-99d5-4710-a063-ca9a62d425c5@intel.com> (raw)
In-Reply-To: <091fa6fa-0f1d-40b3-9c32-8401306f0e66@molgen.mpg.de>
>>>> + ret = ice_wait_for_reset(pf, 10 * HZ);
>>>
>>> Why not pass a delay in micro/milliseconds?
>>
>> ice_wait_for_reset() takes jiffies — that's the existing API.
>
> It’s recommended to use `msecs_to_jiffies()` to make it HZ invariant.
there is also secs_to_jiffies()
>
>>>> + if (ret)
>>>> + dev_err(dev, "Wait for reset failed during resume:
>>>> %d\n", ret);
>>>
>>> Mention the delay?
>>
>> Good point. I'll include the timeout in the error message in v3.
>
> Awesome.
>
> […]
>
>
> Thanks,
>
> Paul
next prev parent reply other threads:[~2026-04-28 13:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 3:03 [PATCH v2] ice: wait for reset completion in ice_resume() Aaron Ma
2026-04-24 15:28 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-04-24 23:42 ` Kohei Enju
2026-04-27 9:41 ` [Intel-wired-lan] " Przemek Kitszel
2026-04-27 10:13 ` Paul Menzel
2026-04-28 7:53 ` Aaron Ma
2026-04-28 9:17 ` Paul Menzel
2026-04-28 13:07 ` Przemek Kitszel [this message]
2026-04-29 3:49 ` Aaron Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fd9877a-99d5-4710-a063-ca9a62d425c5@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=aaron.ma@canonical.com \
--cc=akeem.g.abodunrin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kohei@enjuk.jp \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox