From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E49F3C4321E for ; Thu, 1 Dec 2022 11:42:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230239AbiLALmM (ORCPT ); Thu, 1 Dec 2022 06:42:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230462AbiLALlv (ORCPT ); Thu, 1 Dec 2022 06:41:51 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC19098959 for ; Thu, 1 Dec 2022 03:40:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669894856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yW/cZ2Z5o6i4KxEquTb7/X2nGHQmwqZNw+btvVM7fIs=; b=F95Ljwq3imZL2QBW8/7k2fDyy+aJ4+RbEwiexT04o0OfMOyb3sL/RdR5PKMjTBRk0obsET YTfNS4BuJimIKUZ3/mkLxhXiFYPmIE+huKc+GfGQB3uTwHQD4mzPi/d4+2j7lwNcCtu2/K NAqIIYSBPZa1HZhB26te8Hl0l+Aiwq4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-630-t6s-EHQ6MciOYlf1Lfgz0g-1; Thu, 01 Dec 2022 06:40:54 -0500 X-MC-Unique: t6s-EHQ6MciOYlf1Lfgz0g-1 Received: by mail-wm1-f70.google.com with SMTP id c126-20020a1c3584000000b003cfffcf7c1aso2450177wma.0 for ; Thu, 01 Dec 2022 03:40:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yW/cZ2Z5o6i4KxEquTb7/X2nGHQmwqZNw+btvVM7fIs=; b=Zgfvmdy3JIvIzg4MD9aTTK0KNElskjH7aVg3E6jfIX5PaYMnAthWGpOhveTX6MEMKW g02GJaqdltjGwSQCqRUUbv6M0t/OHqK+U28RLoUM/s7sh1F5zh4udMCuZ77uvlHyW2Gy C5On8Oef77zF/BcsEuH0AT/HHmGDN7IgUqlSkOOf0Zz4qx2dT1hkne/2c1JseAC5W2ki JfpY44kwPujNiNWNf/0rdSZ60ttDDCCpU4xpNnlzUKMD5/+Q2Kt746rON4rdTJaR8lQC POTJl1sBPCNdlw2vS3iTdPAsFJEWvoZ3S/V7AfT0FAN4LL1PI5fGu3DYk+ZnTe8ndd0K xikg== X-Gm-Message-State: ANoB5pnAEo1OjDu6q306Gn3aDfXkzri1cbkMJ8+ZK7swU9QHmG2IsaHV Ybn1CcvErowHJGDmFkG3qIona7oMFiHecSOkde0tDivN1cULqvhwKuwRQizb7nmwKa3tgKSqq0e fxvOUPIvxwbscon+I X-Received: by 2002:a05:600c:aca:b0:3c6:6f2c:64ef with SMTP id c10-20020a05600c0aca00b003c66f2c64efmr41468669wmr.91.1669894853535; Thu, 01 Dec 2022 03:40:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf7KYx7l14jHtR36fJ0R07i3GNEthiTcJzcmBeHhKJjQrq0ypw62l+DxXKeXhWGqqRMPx2xXfg== X-Received: by 2002:a05:600c:aca:b0:3c6:6f2c:64ef with SMTP id c10-20020a05600c0aca00b003c66f2c64efmr41468651wmr.91.1669894853321; Thu, 01 Dec 2022 03:40:53 -0800 (PST) Received: from gerbillo.redhat.com (146-241-120-203.dyn.eolo.it. [146.241.120.203]) by smtp.gmail.com with ESMTPSA id w12-20020a05600c474c00b003b435c41103sm11182535wmo.0.2022.12.01.03.40.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 03:40:52 -0800 (PST) Message-ID: <9fdc4e0eee7ead18c119b6bc3e93f7f73d2980cd.camel@redhat.com> Subject: Re: [PATCH v4 net-next 4/6] net: ethernet: ti: am65-cpsw: Add suspend/resume support From: Paolo Abeni To: Roger Quadros , davem@davemloft.net, maciej.fijalkowski@intel.com, kuba@kernel.org Cc: andrew@lunn.ch, edumazet@google.com, vigneshr@ti.com, linux-omap@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 01 Dec 2022 12:40:51 +0100 In-Reply-To: <20221129133501.30659-5-rogerq@kernel.org> References: <20221129133501.30659-1-rogerq@kernel.org> <20221129133501.30659-5-rogerq@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 2022-11-29 at 15:34 +0200, Roger Quadros wrote: > @@ -555,11 +556,26 @@ static int am65_cpsw_nuss_ndo_slave_open(struct net_device *ndev) > struct am65_cpsw_common *common = am65_ndev_to_common(ndev); > struct am65_cpsw_port *port = am65_ndev_to_port(ndev); > int ret, i; > + u32 reg; > > ret = pm_runtime_resume_and_get(common->dev); > if (ret < 0) > return ret; > > + /* Idle MAC port */ > + cpsw_sl_ctl_set(port->slave.mac_sl, CPSW_SL_CTL_CMD_IDLE); > + cpsw_sl_wait_for_idle(port->slave.mac_sl, 100); > + cpsw_sl_ctl_reset(port->slave.mac_sl); > + > + /* soft reset MAC */ > + cpsw_sl_reg_write(port->slave.mac_sl, CPSW_SL_SOFT_RESET, 1); > + mdelay(1); > + reg = cpsw_sl_reg_read(port->slave.mac_sl, CPSW_SL_SOFT_RESET); > + if (reg) { > + dev_err(common->dev, "soft RESET didn't complete\n"); I *think* Andrew was asking for dev_dbg() here, but let's see what he has to say :) Cheers, Paolo