From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH net-next 03/18] net: mvpp2: make sure we use single queue
 mode on PPv2.1
Date: Thu, 12 Jul 2018 17:10:58 +0300
Message-ID: <9fdd233e-5f22-aeb3-c179-f14c6bb960e7@cogentembedded.com>
References: <20180712115427.27375-1-maxime.chevallier@bootlin.com>
 <20180712115427.27375-4-maxime.chevallier@bootlin.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Antoine Tenart <antoine.tenart@bootlin.com>,
        thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com,
        miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com,
        ymarkman@marvell.com, mw@semihalf.com
To: Maxime Chevallier <maxime.chevallier@bootlin.com>,
        davem@davemloft.net
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-lf0-f65.google.com ([209.85.215.65]:36834 "EHLO
        mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726762AbeGLOUr (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 12 Jul 2018 10:20:47 -0400
Received: by mail-lf0-f65.google.com with SMTP id b22-v6so11951982lfa.3
        for <netdev@vger.kernel.org>; Thu, 12 Jul 2018 07:11:02 -0700 (PDT)
In-Reply-To: <20180712115427.27375-4-maxime.chevallier@bootlin.com>
Content-Language: en-MW
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hello!

On 07/12/2018 02:54 PM, Maxime Chevallier wrote:

> The PPv2 driver defines 2 "queue_modes" :
>  - QDIST_SINGLE_MODE, where we each port share one rx queue vector

   Doesn't look like "we" is needed here.

>    between all CPUs
>  - QDIST_MULTI_MODE, where each port has one rx queue vector per CPU.
> 
> Multi queue mode isn't available on PPv2.1, make sure we fallback to
> single mode when running on this revision.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
[...]

MBR, Sergei