* Re: [PATCH] macb: Don't re-enable interrupts while in polling mode
From: David Miller @ 2010-10-24 22:23 UTC (permalink / raw)
To: Joshua.Hoke
Cc: nicolas.ferre, jpirko, peter.korsgaard, eric.dumazet,
haavard.skinnemoen, netdev, linux-kernel, akpm
In-Reply-To: <C8F551D39A7C724E987CF8DD11D3178304D02F88@svr3.sixnetio.com>
From: "Joshua Hoke" <Joshua.Hoke@sixnet.com>
Date: Tue, 19 Oct 2010 12:48:22 -0400
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index ff2f158..36cf594 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -515,14 +515,15 @@ static int macb_poll(struct napi_struct *napi, int
> budget)
Your email client is breaking up long lines which corrupts the
patch.
Please fix this up in your email client and resubmit.
Thank you.
^ permalink raw reply
* Re: [PATCH] pktgen: clean up handling of local/transient counter vars
From: David Miller @ 2010-10-24 22:23 UTC (permalink / raw)
To: paul.gortmaker; +Cc: netdev
In-Reply-To: <1287440084-4848-1-git-send-email-paul.gortmaker@windriver.com>
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Mon, 18 Oct 2010 18:14:44 -0400
> The temporary variable "i" is needlessly initialized to zero
> in two distinct cases in this file:
>
> 1) where it is set to zero and then used as an argument in an addition
> before being assigned a non-zero value.
>
> 2) where it is only used in a standard/typical loop counter
>
> For (1), simply delete assignment to zero and usages while still
> zero; for (2) simply make the loop start at zero as per standard
> practice as seen everywhere else in the same file.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Applied.
^ permalink raw reply
* Re: [PATCH] ip6_tunnel dont update the mtu on the route.
From: David Miller @ 2010-10-24 22:24 UTC (permalink / raw)
To: eric.dumazet; +Cc: Anders.Franzen, netdev
In-Reply-To: <1287498728.2676.110.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 19 Oct 2010 16:32:08 +0200
> Le mardi 19 octobre 2010 à 15:50 +0200, Anders.Franzen@ericsson.com a
> écrit :
>> From: Anders Franzen <anders.franzen@ericsson.com>
>>
>> The ip6_tunnel device did not unset the flag,
>> IFF_XMIT_DST_RELEASE. This will make the dev layer
>> to release the dst before calling the tunnel.
>> The tunnel will not update any mtu/pmtu info, since
>> it does not have a dst on the skb.
...
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
Anders, please provide a proper "Signed-off-by: " tag in your
commit messages in the future.
Thanks.
^ permalink raw reply
* Re: [PATCH net-next-2.6 v2] can: tscan1: add driver for TS-CAN1 boards
From: David Miller @ 2010-10-24 22:27 UTC (permalink / raw)
To: w.sang-bIcnvbaLZ9MEGnE8C9+IrQ
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
netdev-u79uwXL29TY76Z2rM5mHXA, anbadeol-Re5JQEeQqe8AvxtiuMwx3w
In-Reply-To: <20101019192730.GA31336-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Date: Tue, 19 Oct 2010 21:27:30 +0200
> On Tue, Oct 19, 2010 at 08:47:27AM +0100, Andre B. Oliveira wrote:
>> Add driver for Technologic Systems TS-CAN1 PC104 peripheral boards.
>>
>> Signed-off-by: Andre B. Oliveira <anbadeol-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> This one already had a round on the socketcan-list, so:
>
> Reviewed-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Applied, thanks everyone.
^ permalink raw reply
* Re: [Patch] Limit sysctl_tcp_mem and sysctl_udp_mem initializers to prevent integer overflows.
From: David Miller @ 2010-10-24 22:28 UTC (permalink / raw)
To: holt
Cc: w, linux-kernel, netdev, linux-sctp, kuznet, pekkas, jmorris,
yoshfuji, kaber, vladislav.yasevich, sri
In-Reply-To: <20101020120345.436404838@gulag1.americas.sgi.com>
From: Robin Holt <holt@sgi.com>
Date: Wed, 20 Oct 2010 07:03:37 -0500
> Subject: [Patch] Limit sysctl_tcp_mem and sysctl_udp_mem initializers to prevent integer overflows.
>
> On a 16TB x86_64 machine, sysctl_tcp_mem[2], sysctl_udp_mem[2], and
> sysctl_sctp_mem[2] can integer overflow. Set limit such that they are
> maximized without overflowing.
>
> Signed-off-by: Robin Holt <holt@sgi.com>
I'll queue this up for -stable, thanks Robin!
^ permalink raw reply
* Re: [PATCH 1/2 v3] xps: Improvements in TX queue selection
From: David Miller @ 2010-10-24 22:32 UTC (permalink / raw)
To: therbert; +Cc: netdev, eric.dumazet
In-Reply-To: <alpine.DEB.1.00.1010211303390.30535@pokey.mtv.corp.google.com>
From: Tom Herbert <therbert@google.com>
Date: Thu, 21 Oct 2010 13:17:08 -0700 (PDT)
> @@ -822,8 +822,10 @@ static int tcp_transmit_skb(struct sock *sk, struct sk_buff *skb, int clone_it,
> &md5);
> tcp_header_size = tcp_options_size + sizeof(struct tcphdr);
>
> - if (tcp_packets_in_flight(tp) == 0)
> + if (tcp_packets_in_flight(tp) == 0) {
> tcp_ca_event(sk, CA_EVENT_TX_START);
> + skb->ooo_okay = 1;
> + }
>
You'll need to clear this flag the moment the first transmit of
this packet happens, otherwise OOO won't be handled correctly in
the event that fast retransmit is necessary later.
^ permalink raw reply
* Re: [PATCH] ibmveth: Increase default copybreak limits to 2k
From: David Miller @ 2010-10-24 22:40 UTC (permalink / raw)
To: rcj; +Cc: netdev
In-Reply-To: <20101021151746.GB5567@linux.vnet.ibm.com>
From: Robert Jennings <rcj@linux.vnet.ibm.com>
Date: Thu, 21 Oct 2010 10:17:46 -0500
> The value of copybreak is the point where we stop using the bounce
> buffer and start to copy data to new buffers; having the overhead of
> additional TCE entry setup/teardown. For the default MTU of 1500,
> increasing the copybreak value to 2k will result in all packets using
> the bounce buffer now. Expanding the use of the bounce buffer up to 2k
> with the default MTU resulted in ~10% throughput improvement.
On the RX side the copybreak serves another purpose.
First of all, when you RX a < ~128 byte frame, you incur the cost
mostly of the cache miss to touch the packet headers. The extra
allocated SKB and the copy are close to free.
But more importantly, if you always pass the RX descriptor SKB
into the network stack, even for tiny frames, the skb->truesize
(which is what gets charged to the socket) is larger than we
want it to be.
For a 128 byte frame, the socket gets charged the full MTU packet
size. Because that is how much memory it is really using.
This is what the RX side copybreak is dealing with and you
therefore cannot remove it so trivially.
I am not applying this patch.
^ permalink raw reply
* Re: [PATCH net-next-2.6] jme: Support WoL after shutdown
From: David Miller @ 2010-10-24 22:42 UTC (permalink / raw)
To: cooldavid; +Cc: netdev, Taoga, arieslee, devinchiu, hcchao, ethanhsiao
In-Reply-To: <1287711220-20075-1-git-send-email-cooldavid@cooldavid.org>
From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
Date: Fri, 22 Oct 2010 09:33:40 +0800
> From: Guo-Fu Tseng <cooldavid@cooldavid.org>
>
> Adding shutdown function that setup wake if wol is enabled.
> Add jme_phy_on in jme_set_100m_half in case it is shutting down
> or suspending when interface is down(phy_off by default).
>
> Reported_and_helped_by: Сtac <Taoga@yandex.ru>
> Signed-off-by: Guo-Fu Tseng <cooldavid@cooldavid.org>
Applied.
^ permalink raw reply
* Re: [PATCH 0/2] cxgb4 updates
From: David Miller @ 2010-10-24 22:42 UTC (permalink / raw)
To: dm; +Cc: netdev
In-Reply-To: <1287696596-15175-1-git-send-email-dm@chelsio.com>
From: Dimitris Michailidis <dm@chelsio.com>
Date: Thu, 21 Oct 2010 14:29:54 -0700
>
> Here are two patches for cxgb4. The first fixes a crash triggered by
> e6484930d7c73d324bccda7d43d131088da697b9. The second updates the driver
> to utilize the newer VLAN infrastructure. If it's too late for the latter
> let me know and I'll resend it when net-next reopens.
Both applied, thanks!
^ permalink raw reply
* Re: [PATCH 1/3] vmxnet3: remove set_flag_le{16,64} helpers
From: David Miller @ 2010-10-24 22:43 UTC (permalink / raw)
To: harvey.harrison; +Cc: sbhatewara, netdev, shemminger
In-Reply-To: <1287720334-15469-1-git-send-email-harvey.harrison@gmail.com>
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Thu, 21 Oct 2010 21:05:32 -0700
> It's easier to just annotate the constants as little endian types and set/clear
> the flags directly.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/3] vmxnet3: annotate hwaddr members as __iomem pointers
From: David Miller @ 2010-10-24 22:43 UTC (permalink / raw)
To: harvey.harrison; +Cc: sbhatewara, netdev, shemminger
In-Reply-To: <1287720334-15469-2-git-send-email-harvey.harrison@gmail.com>
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Thu, 21 Oct 2010 21:05:33 -0700
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 3/3] vmxnet3: fix typo setting confPA
From: David Miller @ 2010-10-24 22:43 UTC (permalink / raw)
To: harvey.harrison; +Cc: sbhatewara, netdev, shemminger
In-Reply-To: <1287720334-15469-3-git-send-email-harvey.harrison@gmail.com>
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Thu, 21 Oct 2010 21:05:34 -0700
> It's a le64, not a le32, typo in one place only.
>
> Noticed by sparse:
> drivers/net/vmxnet3/vmxnet3_drv.c:2668:52: warning: incorrect type in assignment (different base types)
> drivers/net/vmxnet3/vmxnet3_drv.c:2668:52: expected restricted __le64 [usertype] confPA
> drivers/net/vmxnet3/vmxnet3_drv.c:2668:52: got restricted __le32 [usertype] <noident>
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 3/3] vmxnet3: fix typo setting confPA
From: David Miller @ 2010-10-24 22:44 UTC (permalink / raw)
To: harvey.harrison; +Cc: sbhatewara, netdev, shemminger
In-Reply-To: <AANLkTimy5Pg1aUMfCZG+r+Zb=A_udx8NsYf3TXVHHTsf@mail.gmail.com>
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Fri, 22 Oct 2010 10:52:15 -0700
> On Fri, Oct 22, 2010 at 10:46 AM, Shreyas Bhatewara
> <sbhatewara@vmware.com> wrote:
>>> From: Harvey Harrison [mailto:harvey.harrison@gmail.com]
>>> One question I had when looking into this, why are you doing
>>> byteswapping in the VMXNET_{READ,WRITE}_BAR{0,1}
>>> macros?
>>
>> Because values need to be written in LE orders in registers. For eg. when rx_ring.next2fill index is written to RXPROD reg, it should be converted from CPU order to LE.
>
> Yes, but (unless I'm mistaken) writel always writes out in
> little-endian, so there isn't a need to swap the arguments,
> similarly for readl in the other direction.
That's right, readl() and writel() translate to little-endian.
^ permalink raw reply
* Re: [PATCH net-next-2.6] jme: Support WoL after shutdown
From: David Miller @ 2010-10-24 22:51 UTC (permalink / raw)
To: cooldavid; +Cc: netdev, Taoga, arieslee, devinchiu, hcchao, ethanhsiao
In-Reply-To: <20101024.154227.232753445.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Sun, 24 Oct 2010 15:42:27 -0700 (PDT)
> From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
> Date: Fri, 22 Oct 2010 09:33:40 +0800
>
>> From: Guo-Fu Tseng <cooldavid@cooldavid.org>
>>
>> Adding shutdown function that setup wake if wol is enabled.
>> Add jme_phy_on in jme_set_100m_half in case it is shutting down
>> or suspending when interface is down(phy_off by default).
>>
>> Reported_and_helped_by: Сtac <Taoga@yandex.ru>
>> Signed-off-by: Guo-Fu Tseng <cooldavid@cooldavid.org>
>
> Applied.
Actually, I had to undo this patch. It generates build
failures:
drivers/net/jme.c: In function 'jme_powersave_phy':
drivers/net/jme.c:1672:3: error: implicit declaration of function 'jme_set_100m_half'
drivers/net/jme.c:1675:4: error: implicit declaration of function 'jme_wait_link'
I guess I'm one of the few people who build with CONFIG_PM
disabled :-)
Please fix this up and resubmit your patch.
^ permalink raw reply
* Re: [PATCH 5/9] tproxy: allow non-local binds of IPv6 sockets if IP_TRANSPARENT is enabled
From: David Miller @ 2010-10-24 23:08 UTC (permalink / raw)
To: bazsi; +Cc: yoshfuji, hidden, netdev, netfilter-devel, kaber
In-Reply-To: <1287845294.13882.4.camel@bzorp.lan>
From: Balazs Scheidler <bazsi@balabit.hu>
Date: Sat, 23 Oct 2010 16:48:14 +0200
> IP_TRANSPARENT requires root (more precisely CAP_NET_ADMIN privielges)
> for IPV6.
>
> However as I see right now this check was missed from the IPv6
> implementation.
>
> Is that enough as a safeguard? e.g. something like this:
Applied, thanks everyone.
^ permalink raw reply
* [PATCH v2 net-2.6] jme: Support WoL after shutdown
From: Guo-Fu Tseng @ 2010-10-24 23:14 UTC (permalink / raw)
To: David Miller
Cc: Guo-Fu Tseng, linux-netdev, Ctac, Aries Lee, Devinchiu,
Hsiu-Che Chao, Ethan Hsiao
From: Guo-Fu Tseng <cooldavid@cooldavid.org>
Adding shutdown function that setup wake if wol is enabled.
Add jme_phy_on in jme_set_100m_half in case it is shutting down
or suspending when interface is down(phy_off by default).
v2 updates:
Removed CONFIG_PM ifdef for jme_set_100m_half and jme_wait_link.
It would be nice if it can be applied to net-2.6 along with other patches
sent few days ago. If it is not appropriate, please ignore the net-2.6
request, and apply it to net-next-2.6 as previous patch. :)
Reported-and-helped-by: Сtac <Taoga@yandex.ru>
Signed-off-by: Guo-Fu Tseng <cooldavid@cooldavid.org>
---
drivers/net/jme.c | 45 ++++++++++++++++++++++++++++++---------------
1 files changed, 30 insertions(+), 15 deletions(-)
diff --git a/drivers/net/jme.c b/drivers/net/jme.c
index d7a975e..d85edf3 100644
--- a/drivers/net/jme.c
+++ b/drivers/net/jme.c
@@ -1623,12 +1623,12 @@ err_out:
return rc;
}
-#ifdef CONFIG_PM
static void
jme_set_100m_half(struct jme_adapter *jme)
{
u32 bmcr, tmp;
+ jme_phy_on(jme);
bmcr = jme_mdio_read(jme->dev, jme->mii_if.phy_id, MII_BMCR);
tmp = bmcr & ~(BMCR_ANENABLE | BMCR_SPEED100 |
BMCR_SPEED1000 | BMCR_FULLDPLX);
@@ -1656,7 +1656,6 @@ jme_wait_link(struct jme_adapter *jme)
phylink = jme_linkstat_from_phy(jme);
}
}
-#endif
static inline void
jme_phy_off(struct jme_adapter *jme)
@@ -1664,6 +1663,21 @@ jme_phy_off(struct jme_adapter *jme)
jme_mdio_write(jme->dev, jme->mii_if.phy_id, MII_BMCR, BMCR_PDOWN);
}
+static void
+jme_powersave_phy(struct jme_adapter *jme)
+{
+ if (jme->reg_pmcs) {
+ jme_set_100m_half(jme);
+
+ if (jme->reg_pmcs & (PMCS_LFEN | PMCS_LREN))
+ jme_wait_link(jme);
+
+ jwrite32(jme, JME_PMCS, jme->reg_pmcs);
+ } else {
+ jme_phy_off(jme);
+ }
+}
+
static int
jme_close(struct net_device *netdev)
{
@@ -2991,6 +3005,16 @@ jme_remove_one(struct pci_dev *pdev)
}
+static void
+jme_shutdown(struct pci_dev *pdev)
+{
+ struct net_device *netdev = pci_get_drvdata(pdev);
+ struct jme_adapter *jme = netdev_priv(netdev);
+
+ jme_powersave_phy(jme);
+ pci_pme_active(pdev, true);
+}
+
#ifdef CONFIG_PM
static int
jme_suspend(struct pci_dev *pdev, pm_message_t state)
@@ -3028,19 +3052,9 @@ jme_suspend(struct pci_dev *pdev, pm_message_t state)
tasklet_hi_enable(&jme->rxempty_task);
pci_save_state(pdev);
- if (jme->reg_pmcs) {
- jme_set_100m_half(jme);
-
- if (jme->reg_pmcs & (PMCS_LFEN | PMCS_LREN))
- jme_wait_link(jme);
-
- jwrite32(jme, JME_PMCS, jme->reg_pmcs);
-
- pci_enable_wake(pdev, PCI_D3cold, true);
- } else {
- jme_phy_off(jme);
- }
- pci_set_power_state(pdev, PCI_D3cold);
+ jme_powersave_phy(jme);
+ pci_enable_wake(jme->pdev, PCI_D3hot, true);
+ pci_set_power_state(pdev, PCI_D3hot);
return 0;
}
@@ -3087,6 +3101,7 @@ static struct pci_driver jme_driver = {
.suspend = jme_suspend,
.resume = jme_resume,
#endif /* CONFIG_PM */
+ .shutdown = jme_shutdown,
};
static int __init
--
1.7.2.2
^ permalink raw reply related
* Re: [PATCH 1/5] netdev: bfin_mac: push settings to platform resources
From: David Miller @ 2010-10-24 23:17 UTC (permalink / raw)
To: vapier; +Cc: netdev, uclinux-dist-devel, sonic.zhang
In-Reply-To: <1287727161-24671-1-git-send-email-vapier@gentoo.org>
From: Mike Frysinger <vapier@gentoo.org>
Date: Fri, 22 Oct 2010 01:59:17 -0400
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> Move all the pin settings out of the Kconfig and into the platform
> resources (MII vs RMII). This clean up also lets us push out the
> phy settings so that board porters may control the layout.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
You'll have to approach this differently.
The platform specific bfin_mac changes have to be in place
before this change goes in.
Not the other way around.
Right now, in fact, there is only one blackfin board support
file that has the bfin_mii_bus_platform_data bits, but that's
not even going to compile because this patch being discussed
isn't applied.
You guys really have to sort this stuff out so that things
get staged in cleanly and the tree compiles properly commit
to commit.
Thanks.
^ permalink raw reply
* Re: [PATCH v2 net-2.6] jme: Support WoL after shutdown
From: David Miller @ 2010-10-24 23:18 UTC (permalink / raw)
To: cooldavid; +Cc: netdev, Taoga, arieslee, devinchiu, hcchao, ethanhsiao
In-Reply-To: <1287962062-30714-1-git-send-email-cooldavid@cooldavid.org>
From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
Date: Mon, 25 Oct 2010 07:14:22 +0800
> From: Guo-Fu Tseng <cooldavid@cooldavid.org>
>
> Adding shutdown function that setup wake if wol is enabled.
> Add jme_phy_on in jme_set_100m_half in case it is shutting down
> or suspending when interface is down(phy_off by default).
>
> v2 updates:
> Removed CONFIG_PM ifdef for jme_set_100m_half and jme_wait_link.
> It would be nice if it can be applied to net-2.6 along with other patches
> sent few days ago. If it is not appropriate, please ignore the net-2.6
> request, and apply it to net-next-2.6 as previous patch. :)
>
> Reported-and-helped-by: Сtac <Taoga@yandex.ru>
> Signed-off-by: Guo-Fu Tseng <cooldavid@cooldavid.org>
Applied.
^ permalink raw reply
* Re: [PATCH] cxgb3: slay double assignment
From: David Miller @ 2010-10-24 23:26 UTC (permalink / raw)
To: kyle; +Cc: divy, netdev
In-Reply-To: <20101022180003.GO8332@bombadil.infradead.org>
From: Kyle McMartin <kyle@mcmartin.ca>
Date: Fri, 22 Oct 2010 14:00:03 -0400
> Noticed this while building Fedora today... It's been
> there since around 2007, so I guess a new gcc must be catching
> these.
>
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
This patch doesn't apply.
^ permalink raw reply
* Re: [PATCH] netlink: fix netlink_change_ngroups()
From: David Miller @ 2010-10-24 23:26 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, johannes, paulmck
In-Reply-To: <1287930430.2658.805.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 24 Oct 2010 16:27:10 +0200
> commit 6c04bb18ddd633 (netlink: use call_rcu for netlink_change_ngroups)
> used a somewhat convoluted and racy way to perform call_rcu().
>
> The old block of memory is freed after a grace period, but the rcu_head
> used to track it is located in new block.
>
> This can clash if we call two times or more netlink_change_ngroups(),
> and a block is freed before another. call_rcu() called on different cpus
> makes no guarantee in order of callbacks.
>
> Fix this using a more standard way of handling this : Each block of
> memory contains its own rcu_head, so that no 'use after free' can
> happens.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks a lot.
^ permalink raw reply
* Re: [PATCH 1/2] typhoon: wait for RX mode commands to finish
From: David Miller @ 2010-10-24 23:26 UTC (permalink / raw)
To: dave; +Cc: netdev
In-Reply-To: <1287951621-25170-1-git-send-email-dave@thedillows.org>
From: David Dillow <dave@thedillows.org>
Date: Sun, 24 Oct 2010 16:20:20 -0400
> When adding VLAN devices, we can get several calls to
> typhoon_set_rx_mode() in quick succession. Because we didn't wait for
> the commands to complete, we could run out of command descriptors and
> fail to set the RX mode.
>
> Signed-off-by: David Dillow <dave@thedillows.org>
Applied.
^ permalink raw reply
* Re: [PATCH 2/2] typhoon: update to new VLAN acceleration model
From: David Miller @ 2010-10-24 23:26 UTC (permalink / raw)
To: dave; +Cc: netdev
In-Reply-To: <1287951621-25170-2-git-send-email-dave@thedillows.org>
From: David Dillow <dave@thedillows.org>
Date: Sun, 24 Oct 2010 16:20:21 -0400
> Also correct the byteswapping as we keep the TCI in host order.
>
> Signed-off-by: David Dillow <dave@thedillows.org>
Applied.
^ permalink raw reply
* Re: [PATCH] cxgb3: slay double assignment
From: Kyle McMartin @ 2010-10-24 23:40 UTC (permalink / raw)
To: David Miller; +Cc: kyle, divy, netdev
In-Reply-To: <20101024.162611.02282476.davem@davemloft.net>
On Sun, Oct 24, 2010 at 04:26:11PM -0700, David Miller wrote:
> > Noticed this while building Fedora today... It's been
> > there since around 2007, so I guess a new gcc must be catching
> > these.
> >
> > Signed-off-by: Kyle McMartin <kyle@redhat.com>
>
> This patch doesn't apply.
>
You already merged a patch to fix it, sorry for the noise.
--Kyle
^ permalink raw reply
* Re: [Uclinux-dist-devel] [PATCH 1/5] netdev: bfin_mac: push settings to platform resources
From: Mike Frysinger @ 2010-10-24 23:40 UTC (permalink / raw)
To: David Miller; +Cc: netdev, uclinux-dist-devel
In-Reply-To: <20101024.161722.258113499.davem@davemloft.net>
On Sun, Oct 24, 2010 at 19:17, David Miller wrote:
> From: Mike Frysinger <vapier@gentoo.org>
>> From: Sonic Zhang <sonic.zhang@analog.com>
>>
>> Move all the pin settings out of the Kconfig and into the platform
>> resources (MII vs RMII). This clean up also lets us push out the
>> phy settings so that board porters may control the layout.
>
> You'll have to approach this differently.
>
> The platform specific bfin_mac changes have to be in place
> before this change goes in.
>
> Not the other way around.
>
> Right now, in fact, there is only one blackfin board support
> file that has the bfin_mii_bus_platform_data bits, but that's
> not even going to compile because this patch being discussed
> isn't applied.
>
> You guys really have to sort this stuff out so that things
> get staged in cleanly and the tree compiles properly commit
> to commit.
and i have the Blackfin changes waiting for you to merge this patch.
i can squash them into this change and have you merge the result, or i
can merge it. i dont really care either way.
-mike
^ permalink raw reply
* Re: [Uclinux-dist-devel] [PATCH 1/5] netdev: bfin_mac: push settings to platform resources
From: David Miller @ 2010-10-24 23:45 UTC (permalink / raw)
To: vapier; +Cc: netdev, uclinux-dist-devel
In-Reply-To: <AANLkTik5_a6t5xJ9TWJf37UCL52O02nAQY4YwB6mgnQx@mail.gmail.com>
From: Mike Frysinger <vapier@gentoo.org>
Date: Sun, 24 Oct 2010 19:40:31 -0400
> and i have the Blackfin changes waiting for you to merge this patch.
> i can squash them into this change and have you merge the result, or i
> can merge it. i dont really care either way.
Why don't you just apply this to your tree then. Feel free to add my:
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox