From: graham.gower@gmail.com
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"shemminger@vyatta.com" <shemminger@vyatta.com>
Subject: Re: [PATCH v4] skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.
Date: Mon, 8 Oct 2012 19:38:06 +1030 [thread overview]
Message-ID: <A11ABB5B-9E22-4FD2-9008-BCD33E64B514@gmail.com> (raw)
In-Reply-To: <20121008.030707.864754447318232909.davem@davemloft.net>
Well its pretty frustrating from my end too.
Fuck it, i dont care enough. I'll just keep patching kernels locally until my hardware expires.
On 08/10/2012, at 5:37 PM, David Miller <davem@davemloft.net> wrote:
> From: Graham Gower <graham.gower@gmail.com>
> Date: Mon, 08 Oct 2012 17:13:24 +1030
>
>> Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to
>> send/receive
>> packets on a system with >4gb ram unless a 32bit DMA mask is used.
>
> Please format this ascii text properly. WHy is there a line
> with just two words surrounded by full nearly 80-column lines?
>
>> + .matches = {
>> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
>
> THis is still formatted incorrectly, it's actually in the file
> not due to your email client.
>
> Can you indent the thing properly, please?
>
> This is V4 of this patch, and suffering purely from first order coding
> style and procedural stuff. As you can imagine, it's very frustrating
> to have to spend this much time getting such simple things taken care
> of.
prev parent reply other threads:[~2012-10-08 9:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 6:43 [PATCH v4] skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard Graham Gower
2012-10-08 7:07 ` David Miller
2012-10-08 9:08 ` graham.gower [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A11ABB5B-9E22-4FD2-9008-BCD33E64B514@gmail.com \
--to=graham.gower@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox