From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lawrence Brakmo Subject: Re: [PATCH bpf-next v6 05/11] bpf: Adds field bpf_sock_ops_cb_flags to tcp_sock Date: Sat, 20 Jan 2018 07:50:59 +0000 Message-ID: References: <20180120014548.2941040-1-brakmo@fb.com> <20180120014548.2941040-6-brakmo@fb.com> <20180120035220.rg55abc6gk2alere@ast-mbp> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: netdev , Kernel Team , "Blake Matheny" , Alexei Starovoitov , Daniel Borkmann , Eric Dumazet , Neal Cardwell , Yuchung Cheng To: Alexei Starovoitov Return-path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:41526 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbeATHv1 (ORCPT ); Sat, 20 Jan 2018 02:51:27 -0500 In-Reply-To: <20180120035220.rg55abc6gk2alere@ast-mbp> Content-Language: en-US Content-ID: <83DBB25A0ABEA94682589903F90D9D54@namprd15.prod.outlook.com> Sender: netdev-owner@vger.kernel.org List-ID: T24gMS8xOS8xOCwgNzo1MiBQTSwgIkFsZXhlaSBTdGFyb3ZvaXRvdiIgPGFsZXhlaS5zdGFyb3Zv aXRvdkBnbWFpbC5jb20+IHdyb3RlOg0KDQogICAgT24gRnJpLCBKYW4gMTksIDIwMTggYXQgMDU6 NDU6NDJQTSAtMDgwMCwgTGF3cmVuY2UgQnJha21vIHdyb3RlOg0KICAgID4gQWRkcyBmaWVsZCBi cGZfc29ja19vcHNfY2JfZmxhZ3MgdG8gdGNwX3NvY2sgYW5kIGJwZl9zb2NrX29wcy4gSXRzIHBy aW1hcnkNCiAgICA+IHVzZSBpcyB0byBkZXRlcm1pbmUgaWYgdGhlcmUgc2hvdWxkIGJlIGNhbGxz IHRvIHNvY2tfb3BzIGJwZiBwcm9ncmFtIGF0DQogICAgPiB2YXJpb3VzIHBvaW50cyBpbiB0aGUg VENQIGNvZGUuIFRoZSBmaWVsZCBpcyBpbml0aWFsaXplZCB0byB6ZXJvLA0KICAgID4gZGlzYWJs aW5nIHRoZSBjYWxscy4gQSBzb2NrX29wcyBCUEYgcHJvZ3JhbSBjYW4gc2V0IGl0LCBwZXIgY29u bmVjdGlvbiBhbmQNCiAgICA+IGFzIG5lY2Vzc2FyeSwgd2hlbiB0aGUgY29ubmVjdGlvbiBpcyBl c3RhYmxpc2hlZC4NCiAgICA+IA0KICAgID4gSXQgYWxzbyBhZGRzIHN1cHBvcnQgZm9yIHJlYWRp bmcgYW5kIHdyaXR0aW5nIHRoZSBmaWVsZCB3aXRoaW4gYQ0KICAgID4gc29ja19vcHMgQlBGIHBy b2dyYW0uIFJlYWRpbmcgaXMgZG9uZSBieSBhY2Nlc3NpbmcgdGhlIGZpZWxkIGRpcmVjdGx5Lg0K ICAgID4gSG93ZXZlciwgd3JpdGluZyBpcyBkb25lIHRocm91Z2ggdGhlIGhlbHBlciBmdW5jdGlv bg0KICAgID4gYnBmX3NvY2tfb3BzX2NiX2ZsYWdzX3NldCwgaW4gb3JkZXIgdG8gcmV0dXJuIGFu IGVycm9yIGlmIGEgQlBGIHByb2dyYW0NCiAgICA+IGlzIHRyeWluZyB0byBzZXQgYSBjYWxsYmFj ayB0aGF0IGlzIG5vdCBzdXBwb3J0ZWQgaW4gdGhlIGN1cnJlbnQga2VybmVsDQogICAgPiAoaS5l LiBydW5uaW5nIGFuIG9sZGVyIGtlcm5lbCkuIFRoZSBoZWxwZXIgZnVuY3Rpb24gcmV0dXJucyAw IGlmIGl0IHdhcw0KICAgID4gYWJsZSB0byBzZXQgYWxsIG9mIHRoZSBiaXRzIHNldCBpbiB0aGUg YXJndW1lbnQsIGEgcG9zaXRpdmUgbnVtYmVyDQogICAgPiBjb250YWluaW5nIHRoZSBiaXRzIHRo YXQgY291bGQgbm90IGJlIHNldCwgb3IgLUVJTlZBTCBpZiB0aGUgc29ja2V0IGlzDQogICAgPiBu b3QgYSBmdWxsIFRDUCBzb2NrZXQuDQogICAgLi4uDQogICAgPiArLyogU29ja19vcHMgYnBmIHBy b2dyYW0gcmVsYXRlZCB2YXJpYWJsZXMgKi8NCiAgICA+ICsjaWZkZWYgQ09ORklHX0JQRg0KICAg ID4gKwl1OAlicGZfc29ja19vcHNfY2JfZmxhZ3M7ICAvKiBDb250cm9sIGNhbGxpbmcgQlBGIHBy b2dyYW1zDQogICAgPiArCQkJCQkgKiB2YWx1ZXMgZGVmaW5lZCBpbiB1YXBpL2xpbnV4L3RjcC5o DQogICAgDQogICAgSSBndWVzcyB3ZSBjYW4gZXh0ZW5kIHU4IGludG8gdTE2IG9yIG1vcmUgaWYg bmVjZXNzYXJ5IGluIHRoZSBmdXR1cmUuDQogICAgDQpZZXMsIHRoYXQgd2FzIG15IHRob3VnaHQu DQoNCiAgICA+ICsgKiBpbnQgYnBmX3NvY2tfb3BzX2NiX2ZsYWdzX3NldChicGZfc29ja19vcHMs IGZsYWdzKQ0KICAgID4gKyAqICAgICBTZXQgY2FsbGJhY2sgZmxhZ3MgZm9yIHNvY2tfb3BzDQog ICAgPiArICogICAgIEBicGZfc29ja19vcHM6IHBvaW50ZXIgdG8gYnBmX3NvY2tfb3BzX2tlcm4g c3RydWN0DQogICAgPiArICogICAgIEBmbGFnczogZmxhZ3MgdmFsdWUNCiAgICA+ICsgKiAgICAg UmV0dXJuOiAwIGZvciBubyBlcnJvcg0KICAgID4gKyAqICAgICAgICAgICAgIC1FSU5WQUwgaWYg dGhlcmUgaXMgbm8gZnVsbCB0Y3Agc29ja2V0DQogICAgPiArICogICAgICAgICAgICAgYml0cyBp biBmbGFncyB0aGF0IGFyZSBub3Qgc3VwcG9ydGVkIGJ5IGN1cnJlbnQga2VybmVsDQogICAgLi4u DQogICAgPiArQlBGX0NBTExfMihicGZfc29ja19vcHNfY2JfZmxhZ3Nfc2V0LCBzdHJ1Y3QgYnBm X3NvY2tfb3BzX2tlcm4gKiwgYnBmX3NvY2ssDQogICAgPiArCSAgIGludCwgYXJndmFsKQ0KICAg ID4gK3sNCiAgICA+ICsJc3RydWN0IHNvY2sgKnNrID0gYnBmX3NvY2stPnNrOw0KICAgID4gKwlp bnQgdmFsID0gYXJndmFsICYgQlBGX1NPQ0tfT1BTX0FMTF9DQl9GTEFHUzsNCiAgICA+ICsNCiAg ICA+ICsJaWYgKCFza19mdWxsc29jayhzaykpDQogICAgPiArCQlyZXR1cm4gLUVJTlZBTDsNCiAg ICA+ICsNCiAgICA+ICsjaWZkZWYgQ09ORklHX0lORVQNCiAgICA+ICsJaWYgKHZhbCkNCiAgICA+ ICsJCXRjcF9zayhzayktPmJwZl9zb2NrX29wc19jYl9mbGFncyA9IHZhbDsNCiAgICA+ICsNCiAg ICA+ICsJcmV0dXJuIGFyZ3ZhbCAmICh+QlBGX1NPQ0tfT1BTX0FMTF9DQl9GTEFHUyk7DQogICAg DQogICAgaW50ZXJlc3RpbmcgaWRlYSEgdG9vayBtZSBzb21lIHRpbWUgdG8gcmVhbGl6ZSB0aGUg cG90ZW50aWFsDQogICAgb2Ygc3VjaCBzZW1hbnRpY3MsIGJ1dCBub3cgSSBsaWtlIGl0IGEgbG90 Lg0KICAgIEl0IGJsZW5kcyAnc2V0IGdvb2QgZmxhZycgd2l0aCAnd2hpY2ggZmxhZ3MgYXJlIHN1 cHBvcnRlZCcgbG9naWMNCiAgICBpbnRvIHNpbmdsZSBoZWxwZXIuIE5pY2UuDQogICAgVGhhbmtz IGZvciBhZGRpbmcgYSB0ZXN0IGZvciBib3RoIHdheXMuDQogICAgQWNrZWQtYnk6IEFsZXhlaSBT dGFyb3ZvaXRvdiA8YXN0QGtlcm5lbC5vcmc+DQogICAgDQogICAgRXJpYywgZG9lcyB0aGlzIGFw cHJvYWNoIGFkZHJlc3MgeW91ciBjb25jZXJucz8NCiAgICANCiAgICANCg0K