From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Williams, Mitch A" Subject: RE: [net-next v2 11/16] i40e: remove chatty log messages Date: Fri, 20 Dec 2013 18:00:23 +0000 Message-ID: References: <1387557965-13241-1-git-send-email-jeffrey.t.kirsher@intel.com> <1387557965-13241-12-git-send-email-jeffrey.t.kirsher@intel.com> <52B489ED.3010704@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "netdev@vger.kernel.org" , "gospo@redhat.com" , "sassmann@redhat.com" , "Brandeburg, Jesse" To: "Williams, Mitch A" , Sergei Shtylyov , "Kirsher, Jeffrey T" , "davem@davemloft.net" Return-path: Received: from mga01.intel.com ([192.55.52.88]:43991 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817Ab3LTSA1 convert rfc822-to-8bit (ORCPT ); Fri, 20 Dec 2013 13:00:27 -0500 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: > -----Original Message----- > From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On > Behalf Of Williams, Mitch A > Sent: Friday, December 20, 2013 9:40 AM > To: Sergei Shtylyov; Kirsher, Jeffrey T; davem@davemloft.net > Cc: netdev@vger.kernel.org; gospo@redhat.com; sassmann@redhat.com; > Brandeburg, Jesse > Subject: RE: [net-next v2 11/16] i40e: remove chatty log messages > > > > > -----Original Message----- > > From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com] > > Sent: Friday, December 20, 2013 10:18 AM > > To: Kirsher, Jeffrey T; davem@davemloft.net; Williams, Mitch A > > Cc: netdev@vger.kernel.org; gospo@redhat.com; sassmann@redhat.com; > > Brandeburg, Jesse > > Subject: Re: [net-next v2 11/16] i40e: remove chatty log messages > > > > On 12/20/2013 07:46 PM, Jeff Kirsher wrote: > > > > > From: Mitch Williams > > > > > Don't complain when we disable queues that are already disable, or > > > enable them when they're already enabled. This removes a bunch of bogus > > > log messages that we see at every VF reset. > > > > > Change-Id: Ia127be572abdccc48a53d8c43f8a07b8bb920de1 > > > Signed-off-by: Mitch Williams > > > Signed-off-by: Jesse Brandeburg > > > Tested-by: Kavindya Deegala > > > Signed-off-by: Jeff Kirsher > > > --- > > > drivers/net/ethernet/intel/i40e/i40e_main.c | 16 +++------------- > > > 1 file changed, 3 insertions(+), 13 deletions(-) > > > > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c > > b/drivers/net/ethernet/intel/i40e/i40e_main.c > > > index c0f78bc..38e07e6 100644 > > > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > > > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > > > @@ -2988,21 +2988,11 @@ static int i40e_vsi_control_tx(struct i40e_vsi > > *vsi, bool enable) > > > } while (j-- && ((tx_reg >> I40E_QTX_ENA_QENA_REQ_SHIFT) > > > ^ (tx_reg >> I40E_QTX_ENA_QENA_STAT_SHIFT)) & > 1); > > > > > > - if (enable) { > > > - /* is STAT set ? */ > > > - if ((tx_reg & I40E_QTX_ENA_QENA_STAT_MASK)) { > > > - dev_info(&pf->pdev->dev, > > > - "Tx %d already enabled\n", i); > > > + /* Skip if the queue is already in the requested state */ > > > + if (enable && (tx_reg & I40E_QTX_ENA_QENA_STAT_MASK)) > > > continue; > > > > This line seems over-indented now. > > > > > - } > > > - } else { > > > - /* is !STAT set ? */ > > > - if (!(tx_reg & I40E_QTX_ENA_QENA_STAT_MASK)) { > > > - dev_info(&pf->pdev->dev, > > > - "Tx %d already disabled\n", i); > > > + if (!enable && !(tx_reg & I40E_QTX_ENA_QENA_STAT_MASK)) > > > continue; > > > > This one too. > > > > WBR, Sergei > > Sergei, if you look at the source instead of the patch, you'll see that > these are correct. The whole thing is inside a for loop, so it should > properly be indented two tabs. > > -Mitch Doh! Jeff pointed out to me that you are indeed correct, Sergei. I was looking at the if lines, not the continue lines. We'll fix this. -Mitch > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html