From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Williams, Mitch A" Subject: RE: [net-next 05/16] i40e: fix long lines Date: Fri, 10 Jan 2014 18:20:26 +0000 Message-ID: References: <1389344336-1558-1-git-send-email-jeffrey.t.kirsher@intel.com> <1389344336-1558-6-git-send-email-jeffrey.t.kirsher@intel.com> <1389344869.24222.31.camel@joe-AO722> <063D6719AE5E284EB5DD2968C1650D6D457950@AcuExch.aculab.com> <1389350138.2537.3.camel@joe-AO722> <1389377693.2537.39.camel@joe-AO722> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: David Laight , "Kirsher, Jeffrey T" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "gospo@redhat.com" , "sassmann@redhat.com" , "Brandeburg, Jesse" To: Joe Perches Return-path: Received: from mga03.intel.com ([143.182.124.21]:54496 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753435AbaAJSU2 convert rfc822-to-8bit (ORCPT ); Fri, 10 Jan 2014 13:20:28 -0500 In-Reply-To: <1389377693.2537.39.camel@joe-AO722> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: > -----Original Message----- > From: Joe Perches [mailto:joe@perches.com] > Sent: Friday, January 10, 2014 10:15 AM > To: Williams, Mitch A > Cc: David Laight; Kirsher, Jeffrey T; davem@davemloft.net; > netdev@vger.kernel.org; gospo@redhat.com; sassmann@redhat.com; Brandeburg, > Jesse > Subject: Re: [net-next 05/16] i40e: fix long lines > > On Fri, 2014-01-10 at 18:05 +0000, Williams, Mitch A wrote: > > > -----Original Message----- > > > From: Joe Perches [mailto:joe@perches.com] > > > Sent: Friday, January 10, 2014 2:36 AM > [] > > > On Fri, 2014-01-10 at 10:02 +0000, David Laight wrote: > > > > > Another way this could be changed is to put the > > > > > return value on a separate line like: > > > > > > > > > > i40e_status > > > > > i40e_aq_set_vsi_unicast_promiscuous(struct i40e_hw *hw, u16 seid, > bool > > > set, > > > > > struct i40e_asq_cmd_details *cmd_details) > > > > > > > > Personally I prefer that so I can find the definition by grepping > > > > for '^function_name' - but it doesn't seem to be done in any linux > > > > source files. > > > > > > That form is used in a lot of files. > > > $ git grep -E "^[a-z_]+\(" > > > > > > > So, Joe, I just want to be clear. Is this a NAK, or just an FYI? > > Hi Mitch. > > This is your/intel's code. I don't/shouldn't nak it. > I made a simple suggestion of an alternate style. > > > If it's a serious issue for you (or Dave), we'll fix it right away. > > It's up to you all to fix it (or not) as you chose. > It's trivial to me. > > cheers, Joe Thanks, Joe. As long as Dave is OK with it, I'll let it stand as-is and scrub the whole driver later for stuff like this. BTW, I appreciate all the time you spend looking at our code. We've got a decent sized team here, but it's always good to have somebody outside the organization keeping us honest. -Mitch