From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrei Emeltchenko Subject: Re: [PATCH] net: bluetooth: fix locking problem Date: Mon, 17 Jan 2011 12:28:29 +0200 Message-ID: References: <1295258917-31092-1-git-send-email-segoon@openwall.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kernel-janitors@vger.kernel.org, Marcel Holtmann , "Gustavo F. Padovan" , "David S. Miller" , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Vasiliy Kulikov Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:47559 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417Ab1AQK2a convert rfc822-to-8bit (ORCPT ); Mon, 17 Jan 2011 05:28:30 -0500 In-Reply-To: <1295258917-31092-1-git-send-email-segoon@openwall.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Jan 17, 2011 at 12:08 PM, Vasiliy Kulikov = wrote: > If alloc_skb() failed we still hold hci_dev_list_lock. =A0The code sh= ould > unlock it before exit. > > Signed-off-by: Vasiliy Kulikov > --- > =A0Compile tested only. > > =A0net/bluetooth/mgmt.c | =A0 =A04 +++- > =A01 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c > index f827fd9..ace8726 100644 > --- a/net/bluetooth/mgmt.c > +++ b/net/bluetooth/mgmt.c > @@ -111,8 +111,10 @@ static int read_index_list(struct sock *sk) > > =A0 =A0 =A0 =A0body_len =3D sizeof(*ev) + sizeof(*rp) + (2 * count); > =A0 =A0 =A0 =A0skb =3D alloc_skb(sizeof(*hdr) + body_len, GFP_ATOMIC)= ; > - =A0 =A0 =A0 if (!skb) > + =A0 =A0 =A0 if (!skb) { > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 read_unlock(&hci_dev_list_lock); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return -ENOMEM; > + =A0 =A0 =A0 } patch was send already on weekend > > =A0 =A0 =A0 =A0hdr =3D (void *) skb_put(skb, sizeof(*hdr)); > =A0 =A0 =A0 =A0hdr->opcode =3D cpu_to_le16(MGMT_EV_CMD_COMPLETE); > -- > 1.7.0.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kerne= l" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at =A0http://vger.kernel.org/majordomo-info.html > Please read the FAQ at =A0http://www.tux.org/lkml/ >