From: Tom Herbert <therbert@google.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: davem@davemloft.net, eilong@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH] bnx2x: Support for managing RX indirection table
Date: Tue, 15 Feb 2011 14:50:18 -0800 [thread overview]
Message-ID: <AANLkTi=VT7BMpJZeE_gKOceNw+=Db40p3znmyt=Jc2Un@mail.gmail.com> (raw)
In-Reply-To: <1297788529.2584.12.camel@bwh-desktop>
>> + u32 rx_indir_table[128];
>
> Shouldn't the dimension be TSTORM_INDIRECTION_TABLE_SIZE?
>
It's not a defined constant, so the alternative would be to malloc it
which seems like overkill to me.
Broadcom guys: are there any adapters or configuration of bnx2x where
the indirection table would be greater than 128?
Tom
next prev parent reply other threads:[~2011-02-15 22:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 16:24 [PATCH] bnx2x: Support for managing RX indirection table Tom Herbert
2011-02-15 16:35 ` Eric Dumazet
2011-02-15 16:48 ` Ben Hutchings
2011-02-15 22:50 ` Tom Herbert [this message]
2011-02-16 5:53 ` Vlad Zolotarov
2011-02-15 17:31 ` Vlad Zolotarov
2011-02-15 17:39 ` Vlad Zolotarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=VT7BMpJZeE_gKOceNw+=Db40p3znmyt=Jc2Un@mail.gmail.com' \
--to=therbert@google.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).