From: Tom Herbert <therbert@google.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: "Michał Mirosław" <mirqus@gmail.com>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: Allow no-cache copy from user on transmit
Date: Wed, 23 Mar 2011 12:48:05 -0700 [thread overview]
Message-ID: <AANLkTi=X8RWFF6ktAxjUTr3iVHPBNOWFpjpuLDzo-06O@mail.gmail.com> (raw)
In-Reply-To: <20110323122544.032fb543@nehalam>
> Isn't nocache DMA a function of the I/O architecture not a function
> of the device driver? Shouldn't it be handled at PCI level somehow
> with considerations of CPU arch and quirks? Doesn't it make sense for
> non-network traffic as well.
>
> Hate to hold up a good optimization while waiting for a general
> solution, but commiting to an API prematurely would be bad as well.
>
There's an implicit assumption in the patch that if somewhere below
the copyfromuser the data is touched it would be more efficient to
copy through the cache than bypass it. Whether the data is touched is
an attribute of the device and hence the per device control.
Now that I think about it, I don't really know what the actual
performance impact is to bypass cache copy and then touch the data.
I'd be interested to know if anyone has data on that, else I'll try to
contrive some benchmark numbers.
Tom
>
>
> --
>
next prev parent reply other threads:[~2011-03-23 19:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 17:10 [PATCH v2] net: Allow no-cache copy from user on transmit Tom Herbert
2011-03-23 18:42 ` Michał Mirosław
2011-03-23 19:25 ` Stephen Hemminger
2011-03-23 19:48 ` Tom Herbert [this message]
2011-03-23 18:51 ` Rick Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=X8RWFF6ktAxjUTr3iVHPBNOWFpjpuLDzo-06O@mail.gmail.com' \
--to=therbert@google.com \
--cc=davem@davemloft.net \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).