Re: [RFC][PATCH]: e1000e: If ASPM L0s needs to be disabled, do it prior to enabling device

[Jeff Kirsher <jeffrey.t.kirsher@intel.com>]

On Tue, Mar 22, 2011 at 12:48, Naga Chumbalkar
<nagananda.chumbalkar@hp.com> wrote:
> If ASPM L0s needs to be disabled due to HW errata, do it prior to
> "enabling" the device. This way if the kernel ever defaults its
> aspm_policy to POLICY_POWERSAVE, then the e1000e driver will get a
> chance to disable ASPM on the misbehaving device *prior* to calling
> pci_enable_device_mem(). This will be useful in situations
> where the BIOS indicates ASPM support on the server by clearing the
> ACPI FADT "ASPM Controls" bit.
>
> Note:
> The kernel (2.6.38) currently uses the BIOS "default" as its aspm_policy.
> However, Linux distros can diverge from that and set the default to "powersave".
>
> Signed-off-by: Naga Chumbalkar <nagananda.chumbalkar@hp.com>
> Cc: Bruce Allan <bruce.w.allan@intel.com>
>
> ---
>  drivers/net/e1000e/82571.c  |   10 +++++-----
>  drivers/net/e1000e/e1000.h  |    1 +
>  drivers/net/e1000e/netdev.c |   25 +++++++++++++++++++++----
>  3 files changed, 27 insertions(+), 9 deletions(-)
>

I have added this patch to my queue of e1000e patches.

-- 
Cheers,
Jeff