[PATCH net-next-2.6] xfrm: cleanup of xfrm_input.c.

[PATCH net-next-2.6] xfrm: cleanup of xfrm_input.c.

[Rami Rosen]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

Hi,
 The patch removes unneeded inclusion of header files
(linux/module.h, linux/netdevice.h, net/dst.h and net/ip.h)
 in net/xfrm/xfrm_input.c

Regards,
Rami Rosen

Signed-off-by: Rami Rosen <ramirose@gmail.com>

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 376 bytes --]

diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c
index 45f1c98..662d3fe 100644
--- a/net/xfrm/xfrm_input.c
+++ b/net/xfrm/xfrm_input.c
@@ -8,10 +8,6 @@
  */
 
 #include <linux/slab.h>
-#include <linux/module.h>
-#include <linux/netdevice.h>
-#include <net/dst.h>
-#include <net/ip.h>
 #include <net/xfrm.h>
 
 static struct kmem_cache *secpath_cachep __read_mostly;

Re: [PATCH net-next-2.6] xfrm: cleanup of xfrm_input.c.

[David Miller]

From: Rami Rosen <ramirose@gmail.com>
Date: Wed, 14 Jul 2010 11:18:41 +0300

> Hi,
>  The patch removes unneeded inclusion of header files
> (linux/module.h, linux/netdevice.h, net/dst.h and net/ip.h)
>  in net/xfrm/xfrm_input.c
> 
> Regards,
> Rami Rosen
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

If you do this, I also want to see you add includes for things like
linux/skbuff.h since data structures such as "struct sk_buff"
are used in this file.

Otherwise, this is how we end up with obscure build failures on
some configurations and not others, either now or in the future
when a similar change is made to some header file.