From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Gross Subject: Re: [net-next-2.6 PATCH 2/3] net: remove check for headroom in vlan_dev_create Date: Wed, 3 Nov 2010 17:46:51 -0700 Message-ID: References: <20101031002232.8691.41201.stgit@jf-dev1-dcblab> <20101031002237.8691.6266.stgit@jf-dev1-dcblab> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: davem@davemloft.net, netdev@vger.kernel.org To: John Fastabend Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:59918 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754128Ab0KDAqw (ORCPT ); Wed, 3 Nov 2010 20:46:52 -0400 Received: by wwb13 with SMTP id 13so70446wwb.1 for ; Wed, 03 Nov 2010 17:46:51 -0700 (PDT) In-Reply-To: <20101031002237.8691.6266.stgit@jf-dev1-dcblab> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, Oct 30, 2010 at 5:22 PM, John Fastabend wrote: > It is possible for the headroom to be smaller then the > hard_header_len for a short period of time after toggling > the vlan offload setting. > > This is not a hard error and skb_cow_head is called in > __vlan_put_tag() to resolve this. > > Signed-off-by: John Fastabend Acked-by: Jesse Gross