netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
To: Denis Kirjanov <dkirjanov@hera.kernel.org>
Cc: davem@davemloft.net, shimoda.yoshihiro@renesas.com,
	morimoto.kuninori@renesas.com, netdev@vger.kernel.org
Subject: Re: [PATCH] sh_eth: Fix memleak in sh_mdio_release
Date: Fri, 21 May 2010 07:12:21 +0900	[thread overview]
Message-ID: <AANLkTikXzLHCwIFashAm1Z22Mw6n0TxC0AcBc4ER7zI6@mail.gmail.com> (raw)
In-Reply-To: <20100520140059.GA8968@hera.kernel.org>

Hi, Denis.

2010/5/20 Denis Kirjanov <dkirjanov@hera.kernel.org>:
> Allocated memory for IRQs should be freed when releasing the mii_bus
>
> Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
> ---
>
> drivers/net/sh_eth.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
> index 586ed09..501a55f 100644
> --- a/drivers/net/sh_eth.c
> +++ b/drivers/net/sh_eth.c
> @@ -1294,6 +1294,9 @@ static int sh_mdio_release(struct net_device *ndev)
>        /* remove mdio bus info from net_device */
>        dev_set_drvdata(&ndev->dev, NULL);
>
> +       /* free interrupts memory */
> +       kfree(bus->irq);
> +
>        /* free bitbang info */
>        free_mdio_bitbang(bus);
>
>
Acked-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>

Thanks!

Best regards,
  Nobuhiro

  reply	other threads:[~2010-05-20 22:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-20 14:00 [PATCH] sh_eth: Fix memleak in sh_mdio_release Denis Kirjanov
2010-05-20 22:12 ` Nobuhiro Iwamatsu [this message]
2010-05-21  6:14   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikXzLHCwIFashAm1Z22Mw6n0TxC0AcBc4ER7zI6@mail.gmail.com \
    --to=iwamatsu@nigauri.org \
    --cc=davem@davemloft.net \
    --cc=dkirjanov@hera.kernel.org \
    --cc=morimoto.kuninori@renesas.com \
    --cc=netdev@vger.kernel.org \
    --cc=shimoda.yoshihiro@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).