From: Kay Sievers <kay.sievers@vrfy.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Greg KH <greg@kroah.com>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] Driver-core: Always create class directories fixing the broken network drivers.
Date: Sun, 20 Jun 2010 13:46:20 +0200 [thread overview]
Message-ID: <AANLkTikZAKZA9mfb7RjaqNFnX8gCM3A9PTfH350botL8@mail.gmail.com> (raw)
In-Reply-To: <1277033628.3642.1.camel@jlt3.sipsolutions.net>
On Sun, Jun 20, 2010 at 13:33, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Sun, 2010-06-20 at 12:52 +0200, Kay Sievers wrote:
>
>> As mentioned earlier, It's pretty fragile to change things in this
>> area, and I prefer the broken network driver-core interactions to be
>> fixed instead - even when they are more complicated.
>
> Can you _please_ offer a proper way to fix it then?
Sorry, I have no real experience with the issues created by the
assumption that network driver need to be able to get unloaded while
in use. That's very special, always requires a
compiled-into-the-kernel part of the subsystem, and makes it hard to
work with, as we can not use any of the usual core infrastructure to
solve that.
The only real simple thing that works is splitting the module in two
modules, which isn't really something I would propose.
Maybe the wait-for in the module-exit like your recent mail suggests
works, but I did not try that. Otherwise we can solve this by changing
the net driver and by adding some needed stuff to the core to allow
in-core bus device cleanup.
The class device hierarchy should be removed for proper network
namespace support, it's nothing we properly support with the current
core code. We better don't fiddle around with stuff nobody really
knows what it breaks. Just like I ran into the 'input' stuff now,
which was a really simple case to find.
Kay
next prev parent reply other threads:[~2010-06-20 11:46 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 13:16 sysfs class/net/ problem Johannes Berg
2010-06-02 15:46 ` Greg KH
2010-06-02 15:48 ` Johannes Berg
2010-06-02 16:17 ` Eric W. Biederman
2010-06-02 16:21 ` Johannes Berg
2010-06-02 16:43 ` Eric W. Biederman
2010-06-02 17:00 ` Johannes Berg
2010-06-02 17:23 ` Eric W. Biederman
2010-06-02 17:52 ` Johannes Berg
2010-06-02 18:05 ` Eric W. Biederman
2010-06-02 18:55 ` Johannes Berg
2010-06-02 19:12 ` Johannes Berg
2010-06-02 19:25 ` Johannes Berg
2010-06-02 23:09 ` Eric W. Biederman
2010-06-03 0:53 ` [RFC][PATCH] Fix another namespace issue with devices assigned to classes Eric W. Biederman
2010-06-03 9:30 ` Kay Sievers
2010-06-03 10:00 ` Eric W. Biederman
2010-06-04 6:54 ` Johannes Berg
2010-06-04 8:15 ` Kay Sievers
2010-06-04 8:28 ` Johannes Berg
2010-06-04 8:34 ` Kay Sievers
2010-06-06 13:08 ` Johannes Berg
2010-06-06 17:17 ` Kay Sievers
2010-06-07 9:42 ` Johannes Berg
2010-06-07 9:53 ` Kay Sievers
2010-06-07 10:14 ` Johannes Berg
2010-06-07 11:05 ` Kay Sievers
2010-06-07 11:41 ` Johannes Berg
2010-06-07 12:26 ` Kay Sievers
2010-06-07 12:36 ` Johannes Berg
2010-06-07 12:54 ` Kay Sievers
2010-06-08 9:27 ` Johannes Berg
2010-06-08 9:30 ` Kay Sievers
2010-06-08 9:45 ` Johannes Berg
2010-06-08 11:55 ` Kay Sievers
2010-06-08 12:03 ` Johannes Berg
2010-06-08 13:54 ` Kay Sievers
2010-06-08 14:06 ` Johannes Berg
2010-06-08 14:21 ` Kay Sievers
2010-06-08 14:26 ` Johannes Berg
2010-06-08 14:47 ` Kay Sievers
2010-06-08 15:06 ` Johannes Berg
2010-06-08 16:26 ` Kay Sievers
2010-06-08 16:33 ` Johannes Berg
2010-06-08 16:39 ` Kay Sievers
2010-06-11 9:55 ` Johannes Berg
2010-06-14 9:13 ` Kay Sievers
2010-06-14 9:20 ` Johannes Berg
2010-06-14 9:39 ` Kay Sievers
[not found] ` <bug-16215-7251@https.bugzilla.kernel.org/>
2010-06-20 6:20 ` [PATCH] Driver-core: Always create class directories fixing the broken network drivers Eric W. Biederman
2010-06-20 10:52 ` Kay Sievers
2010-06-20 11:33 ` Johannes Berg
2010-06-20 11:46 ` Kay Sievers [this message]
2010-06-20 12:29 ` Eric W. Biederman
2010-06-20 13:37 ` Kay Sievers
2010-06-20 12:46 ` [PATCH] Driver-core: Always create network class directories in get_device_parent Eric W. Biederman
2010-06-21 22:20 ` Greg KH
2010-06-21 23:00 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikZAKZA9mfb7RjaqNFnX8gCM3A9PTfH350botL8@mail.gmail.com \
--to=kay.sievers@vrfy.org \
--cc=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).