From: Kay Sievers <kay.sievers@vrfy.org>
To: Dan Williams <dcbw@redhat.com>
Cc: netdev@vger.kernel.org, Duncan Sands <duncan.sands@free.fr>,
linux-usb@vger.kernel.org, Chas Williams <chas@cmf.nrl.navy.mil>
Subject: Re: [PATCH] atm: correct sysfs 'device' link creation and parent relationships
Date: Tue, 7 Dec 2010 08:35:53 +0100 [thread overview]
Message-ID: <AANLkTikhkVPcibAH8cSRvZSLop=Ew19Tn=KtY7prkKUn@mail.gmail.com> (raw)
In-Reply-To: <1291587480.17538.12.camel@dcbw.foobar.com>
On Sun, Dec 5, 2010 at 23:17, Dan Williams <dcbw@redhat.com> wrote:
> The ATM subsystem was incorrectly creating the 'device' link for ATM
> nodes in sysfs. This led to incorrect device/parent relationships
> exposed by sysfs and udev. Instead of rolling the 'device' link by hand
> in the generic ATM code, pass each ATM driver's bus device down to the
> sysfs code and let sysfs do this stuff correctly.
Looks good to me.
It's wrong for any subsystem to ever create a file or link named
"device". It's a built-in driver-core managed property which appears
automatically as soon as the parent-device relations are correctly
established.
Udev/libudev intentionally refuses to follow any devices pointed to by
"broken" device links. So this patch is needed to make ATM devices
working properly with usual userspace tools.
Thanks,
Kay
next prev parent reply other threads:[~2010-12-07 7:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-05 22:17 [PATCH] atm: correct sysfs 'device' link creation and parent relationships Dan Williams
2010-12-07 7:35 ` Kay Sievers [this message]
2010-12-08 18:11 ` David Miller
[not found] ` <20101208.101121.71114237.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-12-08 20:15 ` David Miller
[not found] ` <20101208.121532.232745367.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-12-09 0:33 ` Dan Williams
2010-12-09 5:40 ` [PATCH v2] " Dan Williams
2010-12-10 23:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTikhkVPcibAH8cSRvZSLop=Ew19Tn=KtY7prkKUn@mail.gmail.com' \
--to=kay.sievers@vrfy.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=dcbw@redhat.com \
--cc=duncan.sands@free.fr \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).