From: Changli Gao <xiaosuo@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jamal Hadi Salim <hadi@cyberus.ca>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH 4/5 v2] ifb: add multiqueue support
Date: Wed, 15 Dec 2010 08:20:58 +0800 [thread overview]
Message-ID: <AANLkTikucnTO_+g2Fa=ZoMFQYbeiQSvqkJURF254So6d@mail.gmail.com> (raw)
In-Reply-To: <1292342358.5934.10.camel@edumazet-laptop>
On Tue, Dec 14, 2010 at 11:59 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>
> There is a problem here.
>
> You should sum in the loop rx_counters only, (the counters syncp
> protected), and use dev_txq_stats_fold() to get the tx_counters from
> core network.
Hmm, in ifb, txq->tx_counters aren't used in ifb_xmit() but
ri_tasklet(). IOW, rx and tx are reversed. Here I use txq->tx_counters
to reduce duplicate counters in ifb_q_private. Unless these variables
might be accessed outside of ifb, I can use them freely? Thanks.
--
Regards,
Changli Gao(xiaosuo@gmail.com)
next prev parent reply other threads:[~2010-12-15 0:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 15:21 [PATCH 4/5 v2] ifb: add multiqueue support Changli Gao
2010-12-14 15:59 ` Eric Dumazet
2010-12-15 0:20 ` Changli Gao [this message]
2010-12-15 6:37 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTikucnTO_+g2Fa=ZoMFQYbeiQSvqkJURF254So6d@mail.gmail.com' \
--to=xiaosuo@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).