Re: [PATCH net-next-2.6] xfrm: cleanup of xfrm_input.c. (resend)

Re: [PATCH net-next-2.6] xfrm: cleanup of xfrm_input.c. (resend)

[Rami Rosen]

[-- Attachment #1: Type: text/plain, Size: 997 bytes --]

 Hi,
  The patch removes unneeded inclusion of header files
 (linux/module.h, linux/netdevice.h, net/dst.h and net/ip.h) and adds inclusion
of linux/skbuff.h instead, in net/xfrm/xfrm_input.c.

 Regards,
 Rami Rosen


On Thu, Jul 15, 2010 at 3:59 AM, David Miller <davem@davemloft.net> wrote:
> From: Rami Rosen <ramirose@gmail.com>
> Date: Wed, 14 Jul 2010 11:18:41 +0300
>
>> Hi,
>>  The patch removes unneeded inclusion of header files
>> (linux/module.h, linux/netdevice.h, net/dst.h and net/ip.h)
>>  in net/xfrm/xfrm_input.c
>>
>> Regards,
>> Rami Rosen
>>
>> Signed-off-by: Rami Rosen <ramirose@gmail.com>
>
> If you do this, I also want to see you add includes for things like
> linux/skbuff.h since data structures such as "struct sk_buff"
> are used in this file.
>
> Otherwise, this is how we end up with obscure build failures on
> some configurations and not others, either now or in the future
> when a similar change is made to some header file.
>
>

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 464 bytes --]

diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c
index 45f1c98..c87aec8 100644
--- a/net/xfrm/xfrm_input.c
+++ b/net/xfrm/xfrm_input.c
@@ -6,12 +6,9 @@
  * 		Split up af-specific portion
  *
  */
-
+ 
+#include <linux/skbuff.h>
 #include <linux/slab.h>
-#include <linux/module.h>
-#include <linux/netdevice.h>
-#include <net/dst.h>
-#include <net/ip.h>
 #include <net/xfrm.h>
 
 static struct kmem_cache *secpath_cachep __read_mostly;

Re: [PATCH net-next-2.6] xfrm: cleanup of xfrm_input.c. (resend)

[David Miller]

From: Rami Rosen <ramirose@gmail.com>
Date: Thu, 15 Jul 2010 08:21:03 +0300

>  Hi,
>   The patch removes unneeded inclusion of header files
>  (linux/module.h, linux/netdevice.h, net/dst.h and net/ip.h) and adds inclusion
> of linux/skbuff.h instead, in net/xfrm/xfrm_input.c.

Rami, please don't process my feedback like an automaton. :-/

I specifically mentioned linux/skbuff.h because that happened to be
the very first obvious header dependency I found in the xfrm_input.c
file.

There are almost certainly others, and I'd like for you to take the
time to skim over the file and figure out what those might be.

Also, when submitting a new version of a patch, do not hijack the
existing thread.  Instead, make a full fresh submission with a
plain fresh subject line, commit log message, signoff, and patch.