From: Changli Gao <xiaosuo@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: mst@redhat.com, eric.dumazet@gmail.com, socketcan@hartkopp.net,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: af_packet: don't call tpacket_destruct_skb() until the skb is sent out
Date: Wed, 22 Sep 2010 17:24:16 +0800 [thread overview]
Message-ID: <AANLkTimK7iAHBZ4ZFRf11b4z86m8SfhbELwMurNgDVw9@mail.gmail.com> (raw)
In-Reply-To: <20100914.202023.193706826.davem@davemloft.net>
On Wed, Sep 15, 2010 at 11:20 AM, David Miller <davem@davemloft.net> wrote:
>
>
> Changli, I have one other minor request, please name this something
> like "shinfo->data_destructor" and "shinfo->data_destructor_arg".
>
> I think that will make it easier for other humans to understand :)
>
OK. Thanks.
But there is another issue, when splice() is involved. If we splice
the skbs generated by AF_PACKET socket to a pipe, the fragment pages
will be hold by the pipe, but the skbs are freed, and AF_PACKET socket
will been told that the corresponding TX ring buffers are available
for the other uses wrongly.
--
Regards,
Changli Gao(xiaosuo@gmail.com)
prev parent reply other threads:[~2010-09-22 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-11 3:23 [PATCH v2] net: af_packet: don't call tpacket_destruct_skb() until the skb is sent out Changli Gao
2010-09-12 12:13 ` Michael S. Tsirkin
2010-09-15 3:20 ` David Miller
2010-09-15 5:23 ` Michael S. Tsirkin
2010-09-22 9:35 ` Changli Gao
2010-09-22 10:59 ` Michael S. Tsirkin
2010-09-22 9:24 ` Changli Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimK7iAHBZ4ZFRf11b4z86m8SfhbELwMurNgDVw9@mail.gmail.com \
--to=xiaosuo@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).