From mboxrd@z Thu Jan 1 00:00:00 1970 From: Changli Gao Subject: Re: [PATCH v2] net: af_packet: don't call tpacket_destruct_skb() until the skb is sent out Date: Wed, 22 Sep 2010 17:24:16 +0800 Message-ID: References: <1284175403-3228-1-git-send-email-xiaosuo@gmail.com> <20100912121349.GD22982@redhat.com> <20100914.202023.193706826.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: mst@redhat.com, eric.dumazet@gmail.com, socketcan@hartkopp.net, netdev@vger.kernel.org To: David Miller Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:48916 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753262Ab0IVJYh (ORCPT ); Wed, 22 Sep 2010 05:24:37 -0400 Received: by wyf22 with SMTP id 22so277533wyf.19 for ; Wed, 22 Sep 2010 02:24:36 -0700 (PDT) In-Reply-To: <20100914.202023.193706826.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Sep 15, 2010 at 11:20 AM, David Miller wrote: > > > Changli, I have one other minor request, please name this something > like "shinfo->data_destructor" and "shinfo->data_destructor_arg". > > I think that will make it easier for other humans to understand :) > OK. Thanks. But there is another issue, when splice() is involved. If we splice the skbs generated by AF_PACKET socket to a pipe, the fragment pages will be hold by the pipe, but the skbs are freed, and AF_PACKET socket will been told that the corresponding TX ring buffers are available for the other uses wrongly. -- Regards, Changli Gao(xiaosuo@gmail.com)