From mboxrd@z Thu Jan 1 00:00:00 1970 From: Changli Gao Subject: Re: [PATCH 3/3] ifb: move tq from ifb_private Date: Sun, 5 Dec 2010 09:13:53 +0800 Message-ID: References: <1291442121-3302-1-git-send-email-xiaosuo@gmail.com> <1291442121-3302-3-git-send-email-xiaosuo@gmail.com> <4CFA3F01.20109@gmail.com> <1291472889.2159.18.camel@mojatatu> <1291474127.2159.35.camel@mojatatu> <20101204154007.GA1981@del.dom.local> <1291478881.2159.70.camel@mojatatu> <20101204165609.GB1981@del.dom.local> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: jamal , netdev@vger.kernel.org To: Jarek Poplawski Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:60488 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755831Ab0LEBOP (ORCPT ); Sat, 4 Dec 2010 20:14:15 -0500 Received: by fxm20 with SMTP id 20so3294425fxm.19 for ; Sat, 04 Dec 2010 17:14:13 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Dec 5, 2010 at 8:22 AM, Changli Gao wrote: > > The error case handled currently is the original netdev disappears but > the corresponding skbs are still in ifb. > > I do also think checking the return value of netif_rx() and > dev_queue_xmit() can fix more 'problems'. :) > I have posted the V2 and split the bug fix to a separate one. BTW: My ultimate goal is making ifb a multi-queue NIC, and the number of queues is equal to the number of the possible CPUs. -- Regards, Changli Gao(xiaosuo@gmail.com)