From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Sjur_Br=C3=A6ndeland?= Subject: Re: [patch] caif: unlock on error path in cfserl_receive() Date: Wed, 26 May 2010 20:18:36 +0200 Message-ID: References: <20100526151648.GA15439@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Sjur Braendeland , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Dan Carpenter Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:62003 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755109Ab0EZSSj convert rfc822-to-8bit (ORCPT ); Wed, 26 May 2010 14:18:39 -0400 In-Reply-To: <20100526151648.GA15439@bicker> Sender: netdev-owner@vger.kernel.org List-ID: Hi Dan. Dan Carpenter wrote: > There was an spin_unlock missing on the error path. =C2=A0The spin_lo= ck was > tucked in with the declarations so it was hard to spot. =C2=A0I added= a new > line. > > Signed-off-by: Dan Carpenter Acked-by: Sjur Braendeland Well spotted! Thanks for reviewing and fixing this. Regards Sjur