netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Albert Cahalan <acahalan@gmail.com>
To: linux-kernel <linux-kernel@vger.kernel.org>, netdev@vger.kernel.org
Subject: txqueuelen has wrong units; should be time
Date: Sun, 27 Feb 2011 00:44:01 -0500	[thread overview]
Message-ID: <AANLkTimd5GQwtUFP2fD_An=M8ajBD8DJpzxQJezv8fB8@mail.gmail.com> (raw)

(thinking about the bufferbloat problem here)

Setting txqueuelen to some fixed number of packets
seems pretty broken if:

1. a link can vary in speed (802.11 especially)

2. a packet can vary in size (9 KiB jumbograms, etc.)

3. there is other weirdness (PPP compression, etc.)

It really needs to be set to some amount of time,
with the OS accounting for packets in terms of the
time it will take to transmit them. This would need
to account for physical-layer packet headers and
minimum spacing requirements.

I think it could also account for estimated congestion
on the local link, because that effects the rate at which
the queue can empty. An OS can directly observe this
on some types of hardware.

Nanoseconds seems fine; it's unlikely you'd ever want
more than 4.2 seconds (32-bit unsigned) of queue.

I guess there are at least 2 queues of interest, with the
second one being under control of the hardware driver.
Having the kernel split the max time as appropriate for
the hardware seems nicest.

             reply	other threads:[~2011-02-27  5:44 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-27  5:44 Albert Cahalan [this message]
2011-02-27  7:02 ` txqueuelen has wrong units; should be time Mikael Abrahamsson
2011-02-27  7:54   ` Eric Dumazet
2011-02-27  8:27     ` Albert Cahalan
2011-02-27 10:55       ` Jussi Kivilinna
2011-02-27 20:07         ` Eric Dumazet
2011-02-27 21:32           ` Jussi Kivilinna
2011-02-28 11:43           ` Jussi Kivilinna
2011-02-28 13:10             ` Eric Dumazet
2011-02-28 18:31               ` Jussi Kivilinna
2011-02-28 16:11           ` John W. Linville
2011-02-28 16:48             ` Eric Dumazet
2011-02-28 16:55               ` John W. Linville
2011-02-28 17:18                 ` Eric Dumazet
2011-02-28 21:45                 ` John Heffner
2011-03-01  4:11                   ` Albert Cahalan
2011-03-01  4:18                     ` David Miller
2011-03-01  6:54                       ` Albert Cahalan
2011-03-01  7:25                         ` David Miller
2011-03-01  7:26                         ` Eric Dumazet
2011-03-01 19:37                           ` Albert Cahalan
2011-03-01 20:14                             ` Eric Dumazet
2011-03-01 20:16                               ` Eric Dumazet
2011-03-02  3:10                           ` Mikael Abrahamsson
2011-03-02 20:25                             ` Chris Friesen
2011-03-01  5:01                     ` Eric Dumazet
2011-03-01  5:36                       ` Eric Dumazet
2011-02-27 23:33         ` Albert Cahalan
2011-02-28 11:23           ` Jussi Kivilinna
2011-03-02 21:54             ` [RFC LOL OMG] pfifo_lat: qdisc that limits dequeueing based on estimated link latency John W. Linville
2011-03-02 22:08               ` John W. Linville
2011-03-03 12:51               ` Eric Dumazet
2011-02-28 15:38           ` txqueuelen has wrong units; should be time Hagen Paul Pfeifer
2011-02-28 16:37             ` Albert Cahalan
2011-02-28 17:45               ` John W. Linville
2011-02-28 17:20             ` Bill Sommerfeld
2011-02-28 21:51               ` John Heffner
2011-03-01  0:46                 ` Mikael Abrahamsson
2011-03-02  6:25                   ` Stephen Hemminger
2011-03-02  6:41                     ` Mikael Abrahamsson
2011-03-02  7:07                       ` Stephen Hemminger
2011-03-02 16:41                         ` Mikael Abrahamsson
2011-03-02 16:50                           ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimd5GQwtUFP2fD_An=M8ajBD8DJpzxQJezv8fB8@mail.gmail.com' \
    --to=acahalan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).