From: Tom Herbert <therbert@google.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, sridharr@google.com
Subject: Re: [PATCH v3] xmit_compl_seq: information to reclaim vmsplice buffers
Date: Mon, 27 Sep 2010 11:38:36 -0700 [thread overview]
Message-ID: <AANLkTimdrFuYONq6FvBW41AnhpA6Q+acSUmy4CiJatYL@mail.gmail.com> (raw)
In-Reply-To: <20100927172315.GA8387@redhat.com>
>
> Can not packets referencing this memory
> still be outstanding at the NIC device, if retransmit happens
> before the ack but after the packet was passed to a device?
>
> It's true that the reftransmit will likely get discarded
> by the remote end, but this might be a security issue
> if an application puts sensitive data in the buffer
> and that gets inadvertently sent on the wire, can it not?
>
Yes, this hole probably does exist. I don't know how to fix it other
than more API that specifically reports when all references to a
buffer are released. In the case of TCP that probably means we'd need
a destructor.
> --
> MST
>
next prev parent reply other threads:[~2010-09-27 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 21:35 [PATCH v3] xmit_compl_seq: information to reclaim vmsplice buffers Tom Herbert
2010-09-24 1:48 ` Eric Dumazet
2010-09-27 17:23 ` Michael S. Tsirkin
2010-09-27 18:38 ` Tom Herbert [this message]
2010-09-27 19:12 ` Eric Dumazet
2010-09-27 21:49 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimdrFuYONq6FvBW41AnhpA6Q+acSUmy4CiJatYL@mail.gmail.com \
--to=therbert@google.com \
--cc=davem@davemloft.net \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sridharr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).