From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Subject: Re: bnx2 fails to compile on parisc because of missing get_dma_ops() Date: Thu, 17 Jun 2010 00:00:01 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: James Bottomley , "netdev@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , FUJITA Tomonori To: Michael Chan Return-path: Received: from mail-iw0-f174.google.com ([209.85.214.174]:52314 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756869Ab0FQEAE convert rfc822-to-8bit (ORCPT ); Thu, 17 Jun 2010 00:00:04 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Jun 16, 2010 at 11:53 PM, Michael Chan wrote: > Mike Frysinger wrote: >> > The commit that causes the problem: >> > >> > commit a33fa66bcf365ffe5b79d1ae1d3582cc261ae56e >> > Author: Michael Chan >> > Date: =A0 Thu May 6 08:58:13 2010 +0000 >> > >> > =A0 =A0bnx2: Add prefetches to rx path. >> > >> > Looks fairly innocuous by the description. >> > >> > Should parisc have a get_dma_ops()? =A0We don't need one >> because our dma >> > ops are per platform not per bus. >> >> looks like it'll be broken on more than just parisc: >> $ grep get_dma_ops arch/*/include/asm/ -rl | cut -d/ -f 2 >> alpha >> ia64 >> microblaze >> powerpc >> sh >> sparc >> x86 > > Most of these archs use the dma functions in: > > > > so it's not a problem. the grep is showing only the arches that define get_dma_ops (and so the new code works). you'd have to invert the list to see the ones which do not define get_dma_ops(), and the inverted list is larger. that was merely my point. -mike