netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Victor <avictor.za@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: nicolas.ferre@atmel.com, Jamie Iles <jamie@jamieiles.com>,
	plagnioj@jcrosoft.com, linux-arm-kernel@lists.infradead.org,
	netdev@vger.kernel.org
Subject: Re: [PATCHv2 1/9] at91: provide macb clks with "pclk" and "hclk" name
Date: Thu, 17 Mar 2011 11:22:37 +0200	[thread overview]
Message-ID: <AANLkTin9FH2orOaV-6feGDikCGvb3C-Q2CnRzp-Y2S4X@mail.gmail.com> (raw)
In-Reply-To: <20110316083844.GA13262@n2100.arm.linux.org.uk>

hi Russell,

>> There is no reference to a "pclk" or "hclk" in the AT91 architecture.
>> So to avoid possible confusion, maybe create two "fake" clocks both
>> parented to "macb_clk", and add a comment they're only for
>> compatibility with the AVR32.
>
> It doesn't matter what's in the documentation.
>
> What matters more than conforming to documentation is keeping the drivers
> in a clean and maintainable state without throwing lots of ifdefs into
> them.

I'm not saying the drivers need ifdefs, they should request both
"pclk" and "hclk" as suggested.

What I was suggesting is the platform clock setup on AT91 as:
    macb_clk
        |
        +-- hclk
        +-- pclk

rather than:
    pclk
        |
        +-- hclk

Regards,
  Andrew Victor

  reply	other threads:[~2011-03-17  9:22 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-15 10:14 [PATCHv2 0/9] macb: add support for Cadence GEM Jamie Iles
2011-03-15 10:14 ` [PATCHv2 1/9] at91: provide macb clks with "pclk" and "hclk" name Jamie Iles
2011-03-15 12:35   ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-15 12:44     ` Jamie Iles
2011-03-16  6:53   ` avictor.za
2011-03-16  8:38     ` Russell King - ARM Linux
2011-03-17  9:22       ` Andrew Victor [this message]
2011-03-17 10:00         ` Russell King - ARM Linux
2011-03-17 10:09           ` Jamie Iles
2011-03-15 10:14 ` [PATCHv2 2/9] macb: remove conditional clk handling Jamie Iles
2011-03-15 10:14 ` [PATCHv2 3/9] macb: unify at91 and avr32 platform data Jamie Iles
2011-03-15 11:14   ` Peter Korsgaard
2011-03-15 11:34     ` Jamie Iles
2011-03-15 12:36     ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-17  8:43     ` avictor.za
2011-03-17  8:48       ` Peter Korsgaard
2011-03-17  8:58         ` Russell King - ARM Linux
2011-03-17  9:22           ` Peter Korsgaard
2011-03-17  9:34             ` Jamie Iles
2011-03-17 21:51               ` Jamie Iles
2011-03-18 15:41                 ` Russell King - ARM Linux
2011-03-18 15:48                   ` Jamie Iles
2011-03-18 15:54                     ` Russell King - ARM Linux
2011-03-19 15:49                       ` Nicolas Ferre
2011-04-23  5:48                       ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-15 10:14 ` [PATCHv2 4/9] macb: convert printk to netdev_ and friends Jamie Iles
2011-03-15 12:36   ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-15 10:14 ` [PATCHv2 5/9] macb: initial support for Cadence GEM Jamie Iles
2011-03-15 10:14 ` [PATCHv2 6/9] macb: support higher rate GEM MDIO clock divisors Jamie Iles
2011-03-15 10:14 ` [PATCHv2 7/9] macb: support statistics for GEM devices Jamie Iles
2011-03-15 10:14 ` [PATCHv2 8/9] macb: support DMA bus widths > 32 bits Jamie Iles
2011-03-15 10:14 ` [PATCHv2 9/9] macb: allow GEM to have configurable receive buffer size Jamie Iles
2011-03-16 20:17 ` [PATCHv2 0/9] macb: add support for Cadence GEM David Miller
2011-03-21  6:38   ` Nicolas Ferre
2011-03-21 11:18     ` Jamie Iles
2011-03-22 16:18       ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-22 16:39         ` Jamie Iles
2011-03-22 17:55           ` Jamie Iles
2011-03-24 16:25             ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-31  9:40               ` Jamie Iles
2011-04-05 10:28                 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-05 10:49                   ` Jamie Iles
2011-04-05 11:21                     ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-05 11:47                       ` Jamie Iles
2011-04-05 11:57                         ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-05 11:12                   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTin9FH2orOaV-6feGDikCGvb3C-Q2CnRzp-Y2S4X@mail.gmail.com \
    --to=avictor.za@gmail.com \
    --cc=jamie@jamieiles.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).