From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: "Tantilov, Emil S" <emil.s.tantilov@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Allan, Bruce W" <bruce.w.allan@intel.com>,
"Pieper, Jeffrey E" <jeffrey.e.pieper@intel.com>
Subject: Re: [REGRESSION] e1000e stopped working [MANUALLY BISECTED]
Date: Wed, 28 Jul 2010 18:10:58 -0700 [thread overview]
Message-ID: <AANLkTinSOUcAxnqCo9YVVonhZ4sdC8iUK4r6F1+ayKef@mail.gmail.com> (raw)
In-Reply-To: <1280300683.8250.2.camel@maxim-laptop>
On Wed, Jul 28, 2010 at 00:04, Maxim Levitsky <maximlevitsky@gmail.com> wrote:
> On Mon, 2010-07-26 at 03:25 +0300, Maxim Levitsky wrote:
>>
>> This commit, present in net-next, solves the problem:
>>
>> commit 1286950690f0f82ffa504e1e149ee3fdb4c51478
>> Author: Bruce Allan <bruce.w.allan@intel.com>
>> Date: Mon Jul 26 03:19:38 2010 +0300
>>
>> e1000e: cleanup e1000_sw_lcd_config_ich8lan()
>>
>> Do not acquire and release the PHY unnecessarily for parts that return
>> from this workaround without actually accessing the PHY registers.
>>
>> Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
>> Tested-by: Jeff Pieper <jeffrey.e.pieper@intel.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>>
>>
>>
>>
>> Also, the above patch is part of whole series of patches with scary descriptions (that is these fix bugs).
>> If I were you I would send them to Linus for 2.6.35 inclusion too.
>>
>> Best regards,
>> Maxim Levitsky
>>
>>
>>
> ping
>
Sorry for the delayed response. I am working on the issue. Here is
the problem I am having, the patch that fixes the issue you are seeing
is fairly large and is a cleanup to the ich8 function, which as it
stands now, would not be accepted into net-2.6 tree this late into the
-rc cycle. So, what I looking at is, what specifically fixed the
issue you are seeing that resides in that patch, and come up with a
smaller (acceptable) patch that I can submit to net-2.6 now to resolve
your issue.
I have dedicated most of this evening to finding a resolution to your
issue that will be acceptable for the net-2.6 tree. As you noted,
there were several patches before this particular commit that may play
some part in the resolution as well, and that is what I will be
looking into. I greatly appreciate the hard work you have done to
help us resolve this issue, and will make sure you get credit for any
solution I put together to resolve this issue.
--
Cheers,
Jeff
next prev parent reply other threads:[~2010-07-29 1:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-27 17:27 [REGRESSION] e1000e stopped working Maxim Levitsky
2010-06-27 17:29 ` Maxim Levitsky
2010-06-27 17:43 ` Maxim Levitsky
2010-06-27 17:47 ` Maxim Levitsky
2010-06-28 17:04 ` Allan, Bruce W
2010-06-28 17:14 ` Maxim Levitsky
2010-06-29 1:09 ` Allan, Bruce W
2010-06-29 10:32 ` Maxim Levitsky
2010-06-29 18:37 ` Tantilov, Emil S
2010-06-30 22:59 ` Maxim Levitsky
2010-07-04 0:41 ` Maxim Levitsky
2010-07-04 22:48 ` [REGRESSION] e1000e stopped working [MANUALLY BISECTED] Maxim Levitsky
2010-07-05 8:13 ` Jeff Kirsher
2010-07-05 9:58 ` Maxim Levitsky
2010-07-12 15:56 ` Maxim Levitsky
2010-07-12 21:23 ` Tantilov, Emil S
2010-07-13 0:38 ` Maxim Levitsky
2010-07-14 22:56 ` Tantilov, Emil S
2010-07-14 23:33 ` Maxim Levitsky
2010-07-15 18:57 ` Maxim Levitsky
2010-07-15 19:02 ` Tantilov, Emil S
2010-07-15 19:09 ` Maxim Levitsky
2010-07-16 19:25 ` Maxim Levitsky
2010-07-16 23:23 ` Tantilov, Emil S
2010-07-17 13:54 ` Maxim Levitsky
2010-07-26 0:25 ` Maxim Levitsky
2010-07-28 7:04 ` Maxim Levitsky
2010-07-29 1:10 ` Jeff Kirsher [this message]
2010-08-01 2:08 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinSOUcAxnqCo9YVVonhZ4sdC8iUK4r6F1+ayKef@mail.gmail.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=emil.s.tantilov@intel.com \
--cc=jeffrey.e.pieper@intel.com \
--cc=maximlevitsky@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).