Re: [PATCH] iproute2: dont filter cached routes on iproute_get

[Fabio Comolli <fabio.comolli@gmail.com>]

Works for me (for ipv4, I cannot test ipv6).
You can add my Tested-By in case you need it.

Regards,
Fabio



On Thu, Aug 12, 2010 at 11:20 AM, Ulrich Weber <uweber@astaro.com> wrote:
> The patch should be applied on top of iproute2 v2.6.35.
>
> Cheers
>  Ulrich
>
> On 08/12/2010 11:12 AM, Fabio Comolli wrote:
>> Hi.
>> Is this patch supposed to be applied on top of plain iproute2 v2.6.35
>> or on top of the previous Andreas' patch?
>>
>>
>>
>> On Thu, Aug 12, 2010 at 11:05 AM, Ulrich Weber <uweber@astaro.com> wrote:
>>> iproute_get will return cloned routes for IPv4
>>> and cloned as well non-cloned routes for IPv6.
>>>
>>> Therefore RTM_F_CLONED flag should not be checked
>>> for iproute_get routes. Check in print_route will
>>> always fail because valid values are 0 and 1.
>>>
>>> Signed-off-by: Ulrich Weber <uweber@astaro.com>
>>> ---
>>>  ip/iproute.c |    1 +
>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/ip/iproute.c b/ip/iproute.c
>>> index 711576e..b43933c 100644
>>> --- a/ip/iproute.c
>>> +++ b/ip/iproute.c
>>> @@ -1286,6 +1286,7 @@ int iproute_get(int argc, char **argv)
>>>        memset(&req, 0, sizeof(req));
>>>
>>>        iproute_reset_filter();
>>> +       filter.cloned = 2;
>>>
>>>        req.n.nlmsg_len = NLMSG_LENGTH(sizeof(struct rtmsg));
>>>        req.n.nlmsg_flags = NLM_F_REQUEST;
>>> --
>>> 1.7.0.4
>>>
>>>
>
>
> --
> Ulrich Weber | uweber@astaro.com | Software Engineer
> Astaro GmbH & Co. KG | www.astaro.com | Phone +49-721-25516-0 | Fax –200
> An der RaumFabrik 33a | 76227 Karlsruhe | Germany
>