From: Kay Sievers <kay.sievers@vrfy.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Greg KH <greg@kroah.com>, netdev <netdev@vger.kernel.org>
Subject: Re: [RFC][PATCH] Fix another namespace issue with devices assigned to classes
Date: Fri, 4 Jun 2010 10:15:49 +0200 [thread overview]
Message-ID: <AANLkTingSwM7e8ldyT1FplF5WCHBsCBCwNkb5ZPHe6hB@mail.gmail.com> (raw)
In-Reply-To: <1275634452.5189.1.camel@jlt3.sipsolutions.net>
On Fri, Jun 4, 2010 at 08:54, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Wed, 2010-06-02 at 17:53 -0700, Eric W. Biederman wrote:
>
>> Johannes this should fix your issue with mac80211_hwsim, where
>> the device symlink were not destroyed when the driver was removed.
>
> It does, thank you.
>
> FWIW, I'm happy changing hwsim too, but I don't think I quite understand
> what you're proposing in your other email so I'll leave it up to you
> since you now know what is causing the problem :)
Assuming that hwsim is th parent of the network interface, it should
us a "struct bus_type" not a "struct class" for the subsystem it
assigns the devices to.
Classes should not be used for anything completely simple, at best not
be used at all, they are just too simple. We never know about future
requirements, which usually all go wrong with the non-extendable class
logic.
The difference in the code to switch from class to bus should be minimal.
Cheers,
Kay
next prev parent reply other threads:[~2010-06-04 8:22 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 13:16 sysfs class/net/ problem Johannes Berg
2010-06-02 15:46 ` Greg KH
2010-06-02 15:48 ` Johannes Berg
2010-06-02 16:17 ` Eric W. Biederman
2010-06-02 16:21 ` Johannes Berg
2010-06-02 16:43 ` Eric W. Biederman
2010-06-02 17:00 ` Johannes Berg
2010-06-02 17:23 ` Eric W. Biederman
2010-06-02 17:52 ` Johannes Berg
2010-06-02 18:05 ` Eric W. Biederman
2010-06-02 18:55 ` Johannes Berg
2010-06-02 19:12 ` Johannes Berg
2010-06-02 19:25 ` Johannes Berg
2010-06-02 23:09 ` Eric W. Biederman
2010-06-03 0:53 ` [RFC][PATCH] Fix another namespace issue with devices assigned to classes Eric W. Biederman
2010-06-03 9:30 ` Kay Sievers
2010-06-03 10:00 ` Eric W. Biederman
2010-06-04 6:54 ` Johannes Berg
2010-06-04 8:15 ` Kay Sievers [this message]
2010-06-04 8:28 ` Johannes Berg
2010-06-04 8:34 ` Kay Sievers
2010-06-06 13:08 ` Johannes Berg
2010-06-06 17:17 ` Kay Sievers
2010-06-07 9:42 ` Johannes Berg
2010-06-07 9:53 ` Kay Sievers
2010-06-07 10:14 ` Johannes Berg
2010-06-07 11:05 ` Kay Sievers
2010-06-07 11:41 ` Johannes Berg
2010-06-07 12:26 ` Kay Sievers
2010-06-07 12:36 ` Johannes Berg
2010-06-07 12:54 ` Kay Sievers
2010-06-08 9:27 ` Johannes Berg
2010-06-08 9:30 ` Kay Sievers
2010-06-08 9:45 ` Johannes Berg
2010-06-08 11:55 ` Kay Sievers
2010-06-08 12:03 ` Johannes Berg
2010-06-08 13:54 ` Kay Sievers
2010-06-08 14:06 ` Johannes Berg
2010-06-08 14:21 ` Kay Sievers
2010-06-08 14:26 ` Johannes Berg
2010-06-08 14:47 ` Kay Sievers
2010-06-08 15:06 ` Johannes Berg
2010-06-08 16:26 ` Kay Sievers
2010-06-08 16:33 ` Johannes Berg
2010-06-08 16:39 ` Kay Sievers
2010-06-11 9:55 ` Johannes Berg
2010-06-14 9:13 ` Kay Sievers
2010-06-14 9:20 ` Johannes Berg
2010-06-14 9:39 ` Kay Sievers
[not found] ` <bug-16215-7251@https.bugzilla.kernel.org/>
2010-06-20 6:20 ` [PATCH] Driver-core: Always create class directories fixing the broken network drivers Eric W. Biederman
2010-06-20 10:52 ` Kay Sievers
2010-06-20 11:33 ` Johannes Berg
2010-06-20 11:46 ` Kay Sievers
2010-06-20 12:29 ` Eric W. Biederman
2010-06-20 13:37 ` Kay Sievers
2010-06-20 12:46 ` [PATCH] Driver-core: Always create network class directories in get_device_parent Eric W. Biederman
2010-06-21 22:20 ` Greg KH
2010-06-21 23:00 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTingSwM7e8ldyT1FplF5WCHBsCBCwNkb5ZPHe6hB@mail.gmail.com \
--to=kay.sievers@vrfy.org \
--cc=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).