From: Changli Gao <xiaosuo@gmail.com>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Fastabend, John R" <john.r.fastabend@intel.com>,
"Tang, Xinan" <xinan.tang@intel.com>,
Junchang Wang <junchangwang@gmail.com>,
netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] Kernel interfaces for multiqueue aware socket
Date: Thu, 16 Dec 2010 09:28:15 +0800 [thread overview]
Message-ID: <AANLkTingt6SM+uasicwPSJRE5vYpvJ=GyFf3bbKhO72G@mail.gmail.com> (raw)
In-Reply-To: <20101216011425.GA17446@linux-os.sc.intel.com>
On Thu, Dec 16, 2010 at 9:14 AM, Fenghua Yu <fenghua.yu@intel.com> wrote:
>
> SKF_AD_QUEUE doesn't know number of rx queues. Thus user application can't
> specify right SKF_AD_QUEUE.
It is wrong. AFAIK, you can get the queue number through
/sys/class/net/eth*/queues/ or /proc/interrupts
>
> SKF_AD_QUEUE only works for rx. There is no queue bound interfaces for tx.
Do you really need queue number? The packets must be already spreaded
among CPUs, I think you means the current CPU number. Please see
SKF_AD_CPU added by Eric.
>
> I can change the patch set to use SKF_AD_QUEUE by removing the set rx queue
> interface and still keep interfaces of
> #define SIOGNUMRXQUEUE 0x8939 /* Get number of rx queues. */
> #define SIOGNUMTXQUEUE 0x893A /* Get number of tx queues. */
> #define SIOSTXQUEUEMAPPING 0x893C /* Set tx queue mapping. */
> #define SIOGRXQUEUEMAPPING 0x893D /* Get rx queue mapping. */
> #define SIOGTXQUEUEMAPPING 0x893E /* Get tx queue mapping. */
>
>>
>> Also your AF_PACKET patch only address mmaped sockets.
>>
> The new patch set will use SKF_AD_QUEUE for rx. So it won't be limited to mmaped
> sockets.
>
If you turn to SKF_AD_QUEUE, I think no patch for kernel is needed.
--
Regards,
Changli Gao(xiaosuo@gmail.com)
next prev parent reply other threads:[~2010-12-16 1:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 20:02 [PATCH 0/3] Kernel interfaces for multiqueue aware socket Fenghua Yu
2010-12-15 20:02 ` [PATCH 1/3] " Fenghua Yu
2010-12-15 20:48 ` Eric Dumazet
2010-12-15 20:56 ` Eric Dumazet
2010-12-16 1:14 ` Fenghua Yu
2010-12-16 1:23 ` Stephen Hemminger
2010-12-16 1:28 ` Changli Gao [this message]
2010-12-16 2:43 ` Dimitris Michailidis
2010-12-17 6:22 ` Junchang Wang
2010-12-17 6:50 ` Eric Dumazet
2010-12-16 4:44 ` Eric Dumazet
2010-12-17 6:12 ` Junchang Wang
2010-12-16 1:52 ` Junchang Wang
2010-12-16 5:00 ` Eric Dumazet
2010-12-17 6:15 ` Junchang Wang
2010-12-15 20:52 ` John Fastabend
2010-12-15 20:02 ` [PATCH 2/3] net/packet/af_packet.c: implement multiqueue aware socket in af_apcket Fenghua Yu
2010-12-15 20:02 ` [PATCH 3/3] drivers/net/ixgbe/ixgbe_main.c: get tx queue mapping specified in socket Fenghua Yu
2010-12-15 20:54 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTingt6SM+uasicwPSJRE5vYpvJ=GyFf3bbKhO72G@mail.gmail.com' \
--to=xiaosuo@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fenghua.yu@intel.com \
--cc=john.r.fastabend@intel.com \
--cc=junchangwang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xinan.tang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).