From: Jamal Hadi Salim <jhs@mojatatu.com>
To: netdev@vger.kernel.org
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
Victor Nogueira <victor@mojatatu.com>, Vega <vega@nebusec.ai>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Guillaume Nault <gnault@redhat.com>,
Simon Horman <horms@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Jason Wang <jasowangio@gmail.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Ren Wei <n05ec@lzu.edu.cn>, Aaron Conole <aconole@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
Ilya Maximets <i.maximets@ovn.org>,
Martin Varghese <martin.varghese@nokia.com>,
Eric Garver <e@erig.me>, Yi Yang <yi.y.yang@intel.com>,
Jiri Benc <jbenc@redhat.com>,
dev@openvswitch.org
Subject: [PATCH net 0/5] net: reject short linear Ethernet headers from tc actions, tun and OVS
Date: Thu, 22 Oct 2026 05:22:17 -0400 [thread overview]
Message-ID: <ACT-N6N4.v1.r0.20261022051412@mojatatu.com> (raw)
A recent flurry of bug fixes for dealing with kernel crashes around
eth_type_trans() showed up on the list. The earliest attempt to fix
this came from Ren Wei <n05ec@lzu.edu.cn>. There are many others
(but i lost track of them). Ren Wei's latest attempt hit a roadblock
with a NACK from Eric[1] asking to fix at the "producers"
These producers can hand a packet to a shared consumer with less than a
full Ethernet header in the linear area.
This series identifies and fixes the following producers:
1. act_vlan POP_ETH rejects a short linear Ethernet header at the tc
action boundary.
2. act_mpls POP does the same, standalone or chained after POP_ETH.
3. tun keeps the no-offload copy hint safe (raising a short hint instead
of rejecting a valid write) while guaranteeing a linear Ethernet
header for the redirected consumer.
4. OVS pop_mpls(ETH_P_TEB) pulls the inner Ethernet header before
restoring MAC_PROTO_ETHERNET.
5. OVS pop_nsh(TUN_P_ETHERNET) does the same for the NSH producer.
1: https://lore.kernel.org/netdev/e85fa16e-df3c-43dd-bb3a-9edca07200ea@kernel.org/
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Jamal Hadi Salim (5):
net/sched: act_vlan: reject short linear Ethernet headers after POP_ETH
net/sched: act_mpls: reject short linear Ethernet headers after pop
net: tun: keep TUN short linear copy hints safe
net: openvswitch: ensure a linear inner Ethernet header on TEB pop
net: openvswitch: ensure a linear inner Ethernet header on NSH pop
next reply other threads:[~2026-10-22 9:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 9:22 Jamal Hadi Salim [this message]
2026-10-22 9:22 ` [PATCH net 1/5] net/sched: act_vlan: reject short linear Ethernet headers after POP_ETH Jamal Hadi Salim
2026-10-22 9:22 ` [PATCH net 2/5] net/sched: act_mpls: reject short linear Ethernet headers after pop Jamal Hadi Salim
2026-10-22 9:22 ` [PATCH net 3/5] net: tun: keep TUN short linear copy hints safe Jamal Hadi Salim
2026-10-22 9:22 ` [PATCH net 4/5] net: openvswitch: ensure a linear inner Ethernet header on TEB pop Jamal Hadi Salim
2026-10-22 9:22 ` [PATCH net 5/5] net: openvswitch: ensure a linear inner Ethernet header on NSH pop Jamal Hadi Salim
2026-10-22 9:54 ` Jiri Benc
2026-10-22 12:42 ` Ilya Maximets
2026-10-22 17:47 ` Eric Dumazet
2026-10-22 12:41 ` [PATCH net 4/5] net: openvswitch: ensure a linear inner Ethernet header on TEB pop Ilya Maximets
2026-10-22 17:47 ` Eric Dumazet
2026-10-22 15:22 ` [PATCH net 3/5] net: tun: keep TUN short linear copy hints safe Willem de Bruijn
2026-10-22 16:17 ` Jamal Hadi Salim
2026-10-22 18:00 ` Eric Dumazet
2026-10-22 20:18 ` Jamal Hadi Salim
2026-10-22 17:52 ` [PATCH net 2/5] net/sched: act_mpls: reject short linear Ethernet headers after pop Eric Dumazet
2026-10-22 15:21 ` [PATCH net 1/5] net/sched: act_vlan: reject short linear Ethernet headers after POP_ETH Willem de Bruijn
2026-10-22 16:01 ` Jamal Hadi Salim
2026-10-22 17:57 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ACT-N6N4.v1.r0.20261022051412@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=aconole@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=e@erig.me \
--cc=echaudro@redhat.com \
--cc=edumazet@kernel.org \
--cc=gnault@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=jasowangio@gmail.com \
--cc=jbenc@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=martin.varghese@nokia.com \
--cc=n05ec@lzu.edu.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vega@nebusec.ai \
--cc=victor@mojatatu.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=yi.y.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox