From: "Belgazal, Netanel" <netanel@amazon.com>
To: Jakub Kicinski <kubakici@wp.pl>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"Wilson, Matt" <msw@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Schmeilin, Evgeny" <evgenys@amazon.com>,
"Tzalik, Guy" <gtzalik@amazon.com>
Subject: Re: [PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after netdev registered
Date: Fri, 29 Dec 2017 08:00:33 +0000 [thread overview]
Message-ID: <B0951795-C990-49ED-9972-CDEED0F160A6@amazon.com> (raw)
In-Reply-To: <20171228234603.436ba946@cakuba.netronome.com>
Yes, I mean in my driver.
netif_carrier_off() have no effect when netdev is uninitialized.
So I must call it after register_netdev().
On 12/29/17, 9:46 AM, "Jakub Kicinski" <kubakici@wp.pl> wrote:
By "should" you mean in your driver, right? I think calling
netif_carrier_off() on an unregistered netdev is a pretty standard
thing to do for drivers which manage carrier state.
next prev parent reply other threads:[~2017-12-29 8:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-28 21:30 [PATCH net 0/3] bug fixes for ENA Ethernet driver netanel
2017-12-28 21:30 ` [PATCH net 1/3] net: ena: unmask MSI-X only after device initialization is completed netanel
2017-12-28 21:30 ` [PATCH net 2/3] net: ena: fix error handling in ena_down() sequence netanel
2017-12-28 21:30 ` [PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after netdev registered netanel
2017-12-29 7:46 ` Jakub Kicinski
2017-12-29 8:00 ` Belgazal, Netanel [this message]
2017-12-29 8:09 ` Jakub Kicinski
2018-01-02 19:08 ` David Miller
2018-01-02 20:38 ` Belgazal, Netanel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B0951795-C990-49ED-9972-CDEED0F160A6@amazon.com \
--to=netanel@amazon.com \
--cc=aliguori@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=evgenys@amazon.com \
--cc=gtzalik@amazon.com \
--cc=kubakici@wp.pl \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox